* [PATCH v3] git-gui: adjust the minimum height of diff pane for shorter screen height
@ 2009-10-15 5:05 Vietor Liu
2009-10-15 19:57 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Vietor Liu @ 2009-10-15 5:05 UTC (permalink / raw)
To: Shawn O. Pearce; +Cc: git, Johannes Schindelin
When the screen height is shorter (e.g. Netbook screen 1024x600), both the
partial commit pane and the status bar will hide. This patch adjust the
minimum height of the diff pane, allowing the overall window to be shorter
and still display both the entire commit pane and status bar.
Signed-off-by: Vietor Liu <vietor@vxwo.org>
---
git-gui.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index 09b2720..037a1f2 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -3083,7 +3083,7 @@ frame .vpane.lower.diff.body
set ui_diff .vpane.lower.diff.body.t
text $ui_diff -background white -foreground black \
-borderwidth 0 \
- -width 80 -height 15 -wrap none \
+ -width 80 -height 5 -wrap none \
-font font_diff \
-xscrollcommand {.vpane.lower.diff.body.sbx set} \
-yscrollcommand {.vpane.lower.diff.body.sby set} \
--
1.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v3] git-gui: adjust the minimum height of diff pane for shorter screen height
2009-10-15 5:05 [PATCH v3] git-gui: adjust the minimum height of diff pane for shorter screen height Vietor Liu
@ 2009-10-15 19:57 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2009-10-15 19:57 UTC (permalink / raw)
To: Vietor Liu; +Cc: Shawn O. Pearce, git, Johannes Schindelin
Vietor Liu <vietor@vxwo.org> writes:
> When the screen height is shorter (e.g. Netbook screen 1024x600), both the
> partial commit pane and the status bar will hide. This patch adjust the
> minimum height of the diff pane, allowing the overall window to be shorter
> and still display both the entire commit pane and status bar.
Ah, I finally can parse and understand what this s/15/5/ change was about
;-). Perhaps with "s/will hide/are hidden/" it would be perfect?
>
> Signed-off-by: Vietor Liu <vietor@vxwo.org>
> ---
> git-gui.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-gui.sh b/git-gui.sh
> index 09b2720..037a1f2 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -3083,7 +3083,7 @@ frame .vpane.lower.diff.body
> set ui_diff .vpane.lower.diff.body.t
> text $ui_diff -background white -foreground black \
> -borderwidth 0 \
> - -width 80 -height 15 -wrap none \
> + -width 80 -height 5 -wrap none \
> -font font_diff \
> -xscrollcommand {.vpane.lower.diff.body.sbx set} \
> -yscrollcommand {.vpane.lower.diff.body.sby set} \
> --
> 1.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-15 20:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-15 5:05 [PATCH v3] git-gui: adjust the minimum height of diff pane for shorter screen height Vietor Liu
2009-10-15 19:57 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).