From: Bernt Hansen <bernt@norang.ca>
To: git@vger.kernel.org
Cc: Paul Mackerras <paulus@samba.org>, Bernt Hansen <bernt@norang.ca>
Subject: [PATCH 0/2] gitk: Fix error display when Tcl is too old
Date: Sat, 24 Oct 2009 16:20:38 -0400 [thread overview]
Message-ID: <1256415640-10328-1-git-send-email-bernt@norang.ca> (raw)
The following patch series cleans up error message reporting when your
version of Tcl is too old.
The old code checked the Tcl version first and then tried to report
the error with show_error. show_error uses msgcat for translation but
msgcat is not yet initialized when we are checking the Tcl version
requirement.
The first patch moves the initialization of msgcat before the check
for the Tcl version. This version will fail is msgcat is not
available.
The second patch handles the case where the msgcat package is not
available by providing a default mc procedure than just returns the
argument text unchanged (essentially bypassing message text
translation).
This lets us continue to use show_error as-is.
Bernt Hansen (2):
gitk: Initialize msgcat before first use
gitk: Provide a default mc function if msgcat is not available
gitk | 46 ++++++++++++++++++++++++++--------------------
1 files changed, 26 insertions(+), 20 deletions(-)
next reply other threads:[~2009-10-24 20:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-24 20:20 Bernt Hansen [this message]
2009-10-24 20:20 ` [PATCH 1/2] gitk: Initialize msgcat before first use Bernt Hansen
2009-10-31 21:34 ` Pat Thoyts
2009-11-01 13:09 ` Bernt Hansen
2009-11-02 12:41 ` [PATCH] Skip translation of wrong Tcl version text Bernt Hansen
2009-11-03 11:31 ` Paul Mackerras
2009-10-24 20:20 ` [PATCH 2/2] gitk: Provide a default mc function if msgcat is not available Bernt Hansen
2009-10-24 22:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256415640-10328-1-git-send-email-bernt@norang.ca \
--to=bernt@norang.ca \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).