* [PATCH] Prevent git-remote-cvs from segfaulting
@ 2009-10-27 1:43 Sverre Rabbelier
0 siblings, 0 replies; only message in thread
From: Sverre Rabbelier @ 2009-10-27 1:43 UTC (permalink / raw)
To: Git List, Junio C Hamano, Jeff King, Daniel Barkalow,
Shawn O. Pearce
Cc: Sverre Rabbelier
In [0] Shawn identified what caused git-remote-cvs from segfaulting,
which should be fixed as desribed in Daniel's reply to that [1].
In the meanwhile, the current patch fixes the issue until Daniel
submits a patch to fix it properly.
[0] http://thread.gmane.org/gmane.comp.version-control.git/130357/focus=130421
[1] http://thread.gmane.org/gmane.comp.version-control.git/130357/focus=131021
Signed-off-by: Sverre Rabbelier <srabbelier@gmail.com>
Not-Signed-off-by: Jeff King <peff@peff.net>
---
Jeff wrote this total hack but wants no credit, responsibility or
anything else to do with it whatsoever.
I think it might be nice to have this on top of pu until Daniel
submits a proper patch, so that until that time the test suite
does not segfault.
transport-helper.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index 410aa49..d867abb 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -68,6 +68,8 @@ static struct child_process *get_helper(struct transport *transport)
static int disconnect_helper(struct transport *transport)
{
struct helper_data *data = transport->data;
+ if(!data)
+ return 0;
if (data->helper) {
write_str_in_full(data->helper->in, "\n");
close(data->helper->in);
@@ -78,6 +80,7 @@ static int disconnect_helper(struct transport *transport)
free(data->helper);
data->helper = NULL;
}
+ transport->data = NULL;
free(data);
return 0;
}
--
1.6.5.1.125.g76b2.dirty
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-10-27 1:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-27 1:43 [PATCH] Prevent git-remote-cvs from segfaulting Sverre Rabbelier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).