From: Sverre Rabbelier <srabbelier@gmail.com>
To: Git List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Daniel Barkalow <barkalow@iabervon.org>,
Johan Herland <johan@herland.net>
Cc: Daniel Barkalow <barkalow@iabervon.org>
Subject: [PATCH v2 01/13] Fix memory leak in helper method for disconnect
Date: Wed, 4 Nov 2009 20:48:06 +0100 [thread overview]
Message-ID: <1257364098-1685-2-git-send-email-srabbelier@gmail.com> (raw)
In-Reply-To: <1257364098-1685-1-git-send-email-srabbelier@gmail.com>
From: Daniel Barkalow <barkalow@iabervon.org>
Since some cases may need to disconnect from the helper and reconnect,
wrap the function that just disconnects in a function that also frees
transport->data.
Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
---
Moved to the beginning of the series as it is most important.
transport-helper.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index f57e84c..e24fcbb 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -67,6 +67,13 @@ static int disconnect_helper(struct transport *transport)
return 0;
}
+static int release_helper(struct transport *transport)
+{
+ disconnect_helper(transport);
+ free(transport->data);
+ return 0;
+}
+
static int fetch_with_fetch(struct transport *transport,
int nr_heads, const struct ref **to_fetch)
{
@@ -163,6 +170,6 @@ int transport_helper_init(struct transport *transport, const char *name)
transport->data = data;
transport->get_refs_list = get_refs_list;
transport->fetch = fetch;
- transport->disconnect = disconnect_helper;
+ transport->disconnect = release_helper;
return 0;
}
--
1.6.5.2.295.g0d105
next prev parent reply other threads:[~2009-11-04 19:50 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 19:48 [PATCH v2 00/13] Reroll of the remote-vcs-helper series Sverre Rabbelier
2009-11-04 19:48 ` Sverre Rabbelier [this message]
2009-11-04 19:48 ` [PATCH v2 02/13] Allow programs to not depend on remotes having urls Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 03/13] Use a function to determine whether a remote is valid Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 04/13] Allow fetch to modify refs Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 05/13] Add a config option for remotes to specify a foreign vcs Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 06/13] Allow specifying the remote helper in the url Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 07/13] Add support for "import" helper command Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 08/13] Write local refs written by the "import" helper command only once Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 09/13] Honour the refspec when updating refs after import Sverre Rabbelier
2009-11-04 21:20 ` Daniel Barkalow
2009-11-04 21:21 ` Sverre Rabbelier
2009-11-04 21:30 ` Daniel Barkalow
2009-11-05 1:45 ` Sverre Rabbelier
2009-11-05 5:34 ` Daniel Barkalow
2009-11-05 6:53 ` Daniel Barkalow
2009-11-05 23:51 ` Sverre Rabbelier
2009-11-06 0:19 ` Daniel Barkalow
2009-11-06 0:28 ` Sverre Rabbelier
2009-11-06 0:37 ` Daniel Barkalow
2009-11-06 6:05 ` Junio C Hamano
2009-11-04 19:48 ` [PATCH v2 10/13] Allow helpers to report in "list" command that the ref is unchanged Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 11/13] Allow helpers to request the path to the .git directory Sverre Rabbelier
2009-11-04 21:35 ` Daniel Barkalow
2009-11-04 22:06 ` Sverre Rabbelier
2009-11-04 22:27 ` Daniel Barkalow
2009-11-04 22:42 ` Sverre Rabbelier
2009-11-04 23:17 ` Daniel Barkalow
2009-11-04 23:18 ` Sverre Rabbelier
2009-11-04 23:25 ` Daniel Barkalow
2009-11-05 0:04 ` Junio C Hamano
2009-11-05 0:15 ` Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 12/13] Basic build infrastructure for Python scripts Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 13/13] Add Python support library for remote helpers Sverre Rabbelier
2009-11-05 7:55 ` Johan Herland
2009-11-06 0:14 ` Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257364098-1685-2-git-send-email-srabbelier@gmail.com \
--to=srabbelier@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=johan@herland.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).