git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bram Neijt <bneijt@gmail.com>
To: Git mailing list <git@vger.kernel.org>
Subject: [gitweb feature request] Release snapshots with vX.X.X tags
Date: Sun, 08 Nov 2009 12:40:42 +0100	[thread overview]
Message-ID: <1257680442.14087.78.camel@owl> (raw)

[-- Attachment #1: Type: text/plain, Size: 820 bytes --]

Dear list members,

I would like to create release snapshots with a git tag like "v0.0.1".
For proper Debian packaging, a release snapshot of tag "v0.0.1" would
have to be named "project-0.0.1.tar.gz" and contain a single directory
with "project-0.0.1/" in the archive.

Attached is a very dirty patch to the current head of gitweb.perl to
change the snapshot if the requested hash has a tag which matches
"m/^v(.+)\^0$/". This regular expression will probably have to be more
strict then that in the future, but my main concern is the quality of
the patch, and whether or not this feature is something the mainstream
would appreciate.

My question to you all is: would this feature be considered as an
addition, and if so what would be the best way to get this patch into
shape for inclusion?

Greetings,
  Bram Neijt


[-- Attachment #2: tag_version_snapshot_detection.patch --]
[-- Type: text/x-patch, Size: 448 bytes --]

5269a5270,5274
> 	my $tagname = git_get_rev_name_tags($hash);
> 	my $tagversion = "";
> 	if ($tagname =~ m/^v(.+)\^0$/) {
>   	$tagversion = "-" + $1;
> 	}
5275a5281,5288
> 
> 	if($tagversion)	{
> 		$filename .= "$tagversion$known_snapshot_formats{$format}{'suffix'}";
> 	}
> 	else	{
> 		$filename .= "-$hash$known_snapshot_formats{$format}{'suffix'}";
> 	}
> 
5281c5294
< 		"--prefix=$name/", $hash);
---
> 		"--prefix=$name$tagversion/", $hash);

             reply	other threads:[~2009-11-08 11:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-08 11:40 Bram Neijt [this message]
2009-11-08 13:40 ` [gitweb feature request] Release snapshots with vX.X.X tags Jakub Narebski
2009-11-08 14:15   ` [gitweb feature request] Release snapshots with vX.X.X tags [closed] Bram Neijt
2009-11-08 18:53 ` [gitweb feature request] Release snapshots with vX.X.X tags Junio C Hamano
2009-11-08 21:08   ` Bram Neijt
2009-11-08 21:27     ` J.H.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1257680442.14087.78.camel@owl \
    --to=bneijt@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).