From: Stephen Boyd <bebarino@gmail.com>
To: "Björn Gustavsson" <bgustavsson@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 4/4] format-patch: Add "--no-stat" as a synonym for "-p"
Date: Sun, 08 Nov 2009 15:11:06 -0800 [thread overview]
Message-ID: <1257721866.1734.47.camel@swboyd-laptop> (raw)
In-Reply-To: <4AF544DF.6070404@gmail.com>
On Sat, 2009-11-07 at 10:58 +0100, Björn Gustavsson wrote:
> diff --git a/builtin-log.c b/builtin-log.c
> index 9df8dac..968a038 100644
> --- a/builtin-log.c
> +++ b/builtin-log.c
> @@ -925,7 +925,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
> "show patch format instead of default (patch + stat)"),
> OPT_BOOLEAN(0, "ignore-if-in-upstream", &ignore_if_in_upstream,
> "don't include a patch matching a commit upstream"),
> - OPT_BOOLEAN('p', NULL, &use_patch_format,
> + OPT_BOOLEAN('p', "no-stat", &use_patch_format,
> "show patch format instead of default (patch + stat)"),
> OPT_GROUP("Messaging"),
> { OPTION_CALLBACK, 0, "add-header", NULL, "header",
I think this needs to have the OPT_NO_NEG flag so users can't say
--no-no-stat.
next prev parent reply other threads:[~2009-11-08 23:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-07 9:58 [PATCH 4/4] format-patch: Add "--no-stat" as a synonym for "-p" Björn Gustavsson
2009-11-08 23:11 ` Stephen Boyd [this message]
2009-11-09 6:22 ` Björn Gustavsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257721866.1734.47.camel@swboyd-laptop \
--to=bebarino@gmail.com \
--cc=bgustavsson@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox