git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Cc: Jakub Narebski <jnareb@gmail.com>
Subject: [RFC/PATCH 0/3] gitweb: Refactor common parts of log-like views
Date: Fri, 13 Nov 2009 02:02:11 +0100	[thread overview]
Message-ID: <1258074134-27011-1-git-send-email-jnareb@gmail.com> (raw)

This series extracts common parts of log-like views: 'log', 'shortlog'
and 'history' view, into git_log_generic() subroutine.  This
unification of code reduces code duplication, and brings features such
as limiting the list of commits displayed using $hash_parent{,_base}
from 'shortlog' view (added in ec3e97b (gitweb: shortlog now also
obeys $hash_parent, 2008-08-08)).

I have tested this series a bit (it passes both t9500 and t9501 test),
but I didn't test all the corner cases.

This series is preparation for even more refactoring planned, to make
it easier to introduce new log-like action (new log formats).  It
doesn't include (for now) the 'search' view, neither in message search
not in pickaxe search form.

Jakub Narebski (3):
  gitweb: Refactor 'log' action generation, adding git_log_body()
  gitweb: Refactor common parts of 'log' and 'shortlog' views
  gitweb: Make 'history' view (re)use git_log_generic()

 gitweb/gitweb.perl |  269 +++++++++++++++++++++-------------------------------
 1 files changed, 110 insertions(+), 159 deletions(-)

-- 
Jakub Narebski

             reply	other threads:[~2009-11-13  1:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13  1:02 Jakub Narebski [this message]
2009-11-13  1:02 ` [PATCH 1/3] gitweb: Refactor 'log' action generation, adding git_log_body() Jakub Narebski
2009-11-13 23:10   ` Nanako Shiraishi
2009-11-13 23:59     ` Jakub Narebski
2009-11-13  1:02 ` [PATCH 2/3] gitweb: Refactor common parts of 'log' and 'shortlog' views Jakub Narebski
2009-11-13  1:02 ` [PATCH 3/3] gitweb: Make 'history' view (re)use git_log_generic() Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258074134-27011-1-git-send-email-jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).