From: Erik Faye-Lund <kusmabite@googlemail.com>
To: msysgit@googlegroups.com
Cc: git@vger.kernel.org, dotzenlabs@gmail.com,
Erik Faye-Lund <kusmabite@gmail.com>
Subject: [PATCH/RFC 10/11] daemon: use full buffered mode for stderr
Date: Thu, 26 Nov 2009 00:44:19 +0000 [thread overview]
Message-ID: <1259196260-3064-11-git-send-email-kusmabite@gmail.com> (raw)
In-Reply-To: <1259196260-3064-10-git-send-email-kusmabite@gmail.com>
Windows doesn't support line buffered mode for file
streams, so let's just use full buffered mode with
a big buffer ("4096 should be enough for everyone")
and add explicit flushing.
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---
daemon.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/daemon.c b/daemon.c
index 1b0e290..130e951 100644
--- a/daemon.c
+++ b/daemon.c
@@ -66,12 +66,14 @@ static void logreport(int priority, const char *err, va_list params)
syslog(priority, "%s", buf);
} else {
/*
- * Since stderr is set to linebuffered mode, the
+ * Since stderr is set to buffered mode, the
* logging of different processes will not overlap
+ * unless they overflow the (rather big) buffers.
*/
fprintf(stderr, "[%"PRIuMAX"] ", (uintmax_t)getpid());
vfprintf(stderr, err, params);
fputc('\n', stderr);
+ fflush(stderr);
}
}
@@ -1094,7 +1096,7 @@ int main(int argc, char **argv)
set_die_routine(daemon_die);
} else
/* avoid splitting a message in the middle */
- setvbuf(stderr, NULL, _IOLBF, 0);
+ setvbuf(stderr, NULL, _IOFBF, 4096);
if (inetd_mode && (group_name || user_name))
die("--user and --group are incompatible with --inetd");
--
1.6.5.rc2.7.g4f8d3
next prev parent reply other threads:[~2009-11-26 0:45 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 0:44 [PATCH/RFC 00/11] daemon-win32 Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 01/11] mingw: add network-wrappers for daemon Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 02/11] strbuf: add non-variadic function strbuf_vaddf() Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 03/11] mingw: implement syslog Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 04/11] compat: add inet_pton and inet_ntop prototypes Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 05/11] inet_ntop: fix a couple of old-style decls Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 06/11] run-command: add kill_async() and is_async_alive() Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 07/11] run-command: support input-fd Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 08/11] daemon: use explicit file descriptor Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 09/11] daemon: use run-command api for async serving Erik Faye-Lund
2009-11-26 0:44 ` Erik Faye-Lund [this message]
2009-11-26 0:44 ` [PATCH/RFC 11/11] mingw: compile git-daemon Erik Faye-Lund
2009-11-27 21:17 ` [msysGit] " Johannes Sixt
2009-11-27 20:59 ` [msysGit] [PATCH/RFC 09/11] daemon: use run-command api for async serving Johannes Sixt
2009-12-02 15:45 ` Erik Faye-Lund
2009-12-02 19:12 ` Johannes Sixt
2009-12-08 13:36 ` Erik Faye-Lund
2009-11-26 22:03 ` [msysGit] [PATCH/RFC 08/11] daemon: use explicit file descriptor Johannes Sixt
2009-11-27 14:23 ` Erik Faye-Lund
2009-11-27 15:46 ` Erik Faye-Lund
2009-11-27 20:23 ` Johannes Sixt
2009-11-27 20:28 ` Johannes Sixt
2009-12-08 13:38 ` Erik Faye-Lund
2009-11-26 21:53 ` [msysGit] [PATCH/RFC 07/11] run-command: support input-fd Johannes Sixt
2009-11-27 14:39 ` Erik Faye-Lund
2009-11-27 20:14 ` Johannes Sixt
2009-12-08 13:46 ` Erik Faye-Lund
2009-11-26 21:46 ` [msysGit] [PATCH/RFC 06/11] run-command: add kill_async() and is_async_alive() Johannes Sixt
2009-11-27 16:04 ` Erik Faye-Lund
2009-11-27 19:59 ` Johannes Sixt
2009-12-02 15:57 ` Erik Faye-Lund
2009-12-02 19:27 ` Johannes Sixt
2010-01-09 0:49 ` Erik Faye-Lund
2010-01-10 17:06 ` Erik Faye-Lund
2009-11-26 21:23 ` [msysGit] [PATCH/RFC 03/11] mingw: implement syslog Johannes Sixt
2009-11-27 8:09 ` Erik Faye-Lund
2009-11-27 19:23 ` Johannes Sixt
2009-12-08 14:01 ` Erik Faye-Lund
2009-11-26 0:59 ` [PATCH/RFC 02/11] strbuf: add non-variadic function strbuf_vaddf() Junio C Hamano
2009-11-26 10:38 ` Erik Faye-Lund
2009-11-26 11:13 ` Paolo Bonzini
2009-11-26 18:46 ` Junio C Hamano
2009-11-26 23:37 ` Erik Faye-Lund
2009-11-27 7:09 ` Johannes Sixt
2009-11-26 8:24 ` [PATCH/RFC 01/11] mingw: add network-wrappers for daemon Martin Storsjö
2009-11-26 10:43 ` [PATCH] Improve the mingw getaddrinfo stub to handle more use cases Martin Storsjö
2009-11-26 10:46 ` [PATCH/RFC 01/11] mingw: add network-wrappers for daemon Erik Faye-Lund
2009-11-26 11:03 ` Martin Storsjö
2009-12-02 13:01 ` Erik Faye-Lund
2009-12-02 13:21 ` Martin Storsjö
2009-12-02 13:49 ` Erik Faye-Lund
2009-12-02 15:11 ` Erik Faye-Lund
2009-12-02 19:34 ` Johannes Sixt
2009-11-26 20:04 ` [msysGit] [PATCH/RFC 00/11] daemon-win32 Johannes Sixt
-- strict thread matches above, loose matches on Subject: below --
2009-11-26 0:39 Erik Faye-Lund
2009-11-26 0:39 ` [PATCH/RFC 01/11] mingw: add network-wrappers for daemon Erik Faye-Lund
2009-11-26 0:39 ` [PATCH/RFC 02/11] strbuf: add non-variadic function strbuf_vaddf() Erik Faye-Lund
2009-11-26 0:39 ` [PATCH/RFC 03/11] mingw: implement syslog Erik Faye-Lund
2009-11-26 0:39 ` [PATCH/RFC 04/11] compat: add inet_pton and inet_ntop prototypes Erik Faye-Lund
2009-11-26 0:39 ` [PATCH/RFC 05/11] inet_ntop: fix a couple of old-style decls Erik Faye-Lund
2009-11-26 0:39 ` [PATCH/RFC 06/11] run-command: add kill_async() and is_async_alive() Erik Faye-Lund
2009-11-26 0:39 ` [PATCH/RFC 07/11] run-command: support input-fd Erik Faye-Lund
2009-11-26 0:39 ` [PATCH/RFC 08/11] daemon: use explicit file descriptor Erik Faye-Lund
2009-11-26 0:39 ` [PATCH/RFC 09/11] daemon: use run-command api for async serving Erik Faye-Lund
2009-11-26 0:39 ` [PATCH/RFC 10/11] daemon: use full buffered mode for stderr Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259196260-3064-11-git-send-email-kusmabite@gmail.com \
--to=kusmabite@googlemail.com \
--cc=dotzenlabs@gmail.com \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).