git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Erik Faye-Lund <kusmabite@googlemail.com>
To: msysgit@googlegroups.com
Cc: git@vger.kernel.org, dotzenlabs@gmail.com,
	Erik Faye-Lund <kusmabite@gmail.com>
Subject: [PATCH/RFC 01/11] mingw: add network-wrappers for daemon
Date: Thu, 26 Nov 2009 00:44:10 +0000	[thread overview]
Message-ID: <1259196260-3064-2-git-send-email-kusmabite@gmail.com> (raw)
In-Reply-To: <1259196260-3064-1-git-send-email-kusmabite@gmail.com>

From: Mike Pape <dotzenlabs@gmail.com>

git-daemon requires some socket-functionality that is not yet
supported in the Windows-port. This patch adds said functionality,
and makes sure WSAStartup gets called by socket(), since it is the
first network-call in git-daemon. In addition, a check is added to
prevent WSAStartup (and WSACleanup, though atexit) from being
called more than once, since git-daemon calls both socket() and
gethostbyname().

Signed-off-by: Mike Pape <dotzenlabs@gmail.com>
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---
 compat/mingw.c |   60 ++++++++++++++++++++++++++++++++++++++++++++++++++++---
 compat/mingw.h |   16 ++++++++++++++
 2 files changed, 72 insertions(+), 4 deletions(-)

diff --git a/compat/mingw.c b/compat/mingw.c
index 10d6796..458021b 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -983,23 +983,37 @@ char **make_augmented_environ(const char *const *vars)
 	return env;
 }
 
-/* this is the first function to call into WS_32; initialize it */
-#undef gethostbyname
-struct hostent *mingw_gethostbyname(const char *host)
+static void wsa_init(void)
 {
+	static int initialized = 0;
 	WSADATA wsa;
 
+	if (initialized)
+		return;
+
 	if (WSAStartup(MAKEWORD(2,2), &wsa))
 		die("unable to initialize winsock subsystem, error %d",
 			WSAGetLastError());
 	atexit((void(*)(void)) WSACleanup);
+	initialized = 1;
+}
+
+/* this can be the first function to call into WS_32; initialize it */
+#undef gethostbyname
+struct hostent *mingw_gethostbyname(const char *host)
+{
+	wsa_init();
 	return gethostbyname(host);
 }
 
+/* this can be the first function to call into WS_32; initialize it */
 int mingw_socket(int domain, int type, int protocol)
 {
+	SOCKET s;
 	int sockfd;
-	SOCKET s = WSASocket(domain, type, protocol, NULL, 0, 0);
+
+	wsa_init();
+	s = WSASocket(domain, type, protocol, NULL, 0, 0);
 	if (s == INVALID_SOCKET) {
 		/*
 		 * WSAGetLastError() values are regular BSD error codes
@@ -1029,6 +1043,44 @@ int mingw_connect(int sockfd, struct sockaddr *sa, size_t sz)
 	return connect(s, sa, sz);
 }
 
+#undef bind
+int mingw_bind(int sockfd, struct sockaddr *sa, size_t sz)
+{
+	SOCKET s = (SOCKET)_get_osfhandle(sockfd);
+	return bind(s, sa, sz);
+}
+
+#undef setsockopt
+int mingw_setsockopt(int sockfd, int lvl, int optname, void *optval, int optlen)
+{
+	SOCKET s = (SOCKET)_get_osfhandle(sockfd);
+	return setsockopt(s, lvl, optname, (const char*)optval, optlen);
+}
+
+#undef listen
+int mingw_listen(int sockfd, int backlog)
+{
+	SOCKET s = (SOCKET)_get_osfhandle(sockfd);
+	return listen(s, backlog);
+}
+
+#undef accept
+int mingw_accept(int sockfd1, struct sockaddr *sa, socklen_t *sz)
+{
+	int sockfd2;
+
+	SOCKET s1 = (SOCKET)_get_osfhandle(sockfd1);
+	SOCKET s2 = accept(s1, sa, sz);
+
+	/* convert into a file descriptor */
+	if ((sockfd2 = _open_osfhandle(s2, O_RDWR|O_BINARY)) < 0) {
+		closesocket(s2);
+		return error("unable to make a socket file descriptor: %s",
+			strerror(errno));
+	}
+	return sockfd2;
+}
+
 #undef rename
 int mingw_rename(const char *pold, const char *pnew)
 {
diff --git a/compat/mingw.h b/compat/mingw.h
index 1978f8a..f362f61 100644
--- a/compat/mingw.h
+++ b/compat/mingw.h
@@ -5,6 +5,7 @@
  */
 
 typedef int pid_t;
+typedef int socklen_t;
 #define hstrerror strerror
 
 #define S_IFLNK    0120000 /* Symbolic link */
@@ -33,6 +34,9 @@ typedef int pid_t;
 #define F_SETFD 2
 #define FD_CLOEXEC 0x1
 
+#define EAFNOSUPPORT WSAEAFNOSUPPORT
+#define ECONNABORTED WSAECONNABORTED
+
 struct passwd {
 	char *pw_name;
 	char *pw_gecos;
@@ -182,6 +186,18 @@ int mingw_socket(int domain, int type, int protocol);
 int mingw_connect(int sockfd, struct sockaddr *sa, size_t sz);
 #define connect mingw_connect
 
+int mingw_bind(int sockfd, struct sockaddr *sa, size_t sz);
+#define bind mingw_bind
+
+int mingw_setsockopt(int sockfd, int lvl, int optname, void *optval, int optlen);
+#define setsockopt mingw_setsockopt
+
+int mingw_listen(int sockfd, int backlog);
+#define listen mingw_listen
+
+int mingw_accept(int sockfd, struct sockaddr *sa, socklen_t *sz);
+#define accept mingw_accept
+
 int mingw_rename(const char*, const char*);
 #define rename mingw_rename
 
-- 
1.6.5.rc2.7.g4f8d3

  reply	other threads:[~2009-11-26  0:44 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-26  0:44 [PATCH/RFC 00/11] daemon-win32 Erik Faye-Lund
2009-11-26  0:44 ` Erik Faye-Lund [this message]
2009-11-26  0:44   ` [PATCH/RFC 02/11] strbuf: add non-variadic function strbuf_vaddf() Erik Faye-Lund
2009-11-26  0:44     ` [PATCH/RFC 03/11] mingw: implement syslog Erik Faye-Lund
2009-11-26  0:44       ` [PATCH/RFC 04/11] compat: add inet_pton and inet_ntop prototypes Erik Faye-Lund
2009-11-26  0:44         ` [PATCH/RFC 05/11] inet_ntop: fix a couple of old-style decls Erik Faye-Lund
2009-11-26  0:44           ` [PATCH/RFC 06/11] run-command: add kill_async() and is_async_alive() Erik Faye-Lund
2009-11-26  0:44             ` [PATCH/RFC 07/11] run-command: support input-fd Erik Faye-Lund
2009-11-26  0:44               ` [PATCH/RFC 08/11] daemon: use explicit file descriptor Erik Faye-Lund
2009-11-26  0:44                 ` [PATCH/RFC 09/11] daemon: use run-command api for async serving Erik Faye-Lund
2009-11-26  0:44                   ` [PATCH/RFC 10/11] daemon: use full buffered mode for stderr Erik Faye-Lund
2009-11-26  0:44                     ` [PATCH/RFC 11/11] mingw: compile git-daemon Erik Faye-Lund
2009-11-27 21:17                       ` [msysGit] " Johannes Sixt
2009-11-27 20:59                   ` [msysGit] [PATCH/RFC 09/11] daemon: use run-command api for async serving Johannes Sixt
2009-12-02 15:45                     ` Erik Faye-Lund
2009-12-02 19:12                       ` Johannes Sixt
2009-12-08 13:36                         ` Erik Faye-Lund
2009-11-26 22:03                 ` [msysGit] [PATCH/RFC 08/11] daemon: use explicit file descriptor Johannes Sixt
2009-11-27 14:23                   ` Erik Faye-Lund
2009-11-27 15:46                     ` Erik Faye-Lund
2009-11-27 20:23                       ` Johannes Sixt
2009-11-27 20:28                         ` Johannes Sixt
2009-12-08 13:38                           ` Erik Faye-Lund
2009-11-26 21:53               ` [msysGit] [PATCH/RFC 07/11] run-command: support input-fd Johannes Sixt
2009-11-27 14:39                 ` Erik Faye-Lund
2009-11-27 20:14                   ` Johannes Sixt
2009-12-08 13:46                     ` Erik Faye-Lund
2009-11-26 21:46             ` [msysGit] [PATCH/RFC 06/11] run-command: add kill_async() and is_async_alive() Johannes Sixt
2009-11-27 16:04               ` Erik Faye-Lund
2009-11-27 19:59                 ` Johannes Sixt
2009-12-02 15:57                   ` Erik Faye-Lund
2009-12-02 19:27                     ` Johannes Sixt
2010-01-09  0:49                       ` Erik Faye-Lund
2010-01-10 17:06                         ` Erik Faye-Lund
2009-11-26 21:23       ` [msysGit] [PATCH/RFC 03/11] mingw: implement syslog Johannes Sixt
2009-11-27  8:09         ` Erik Faye-Lund
2009-11-27 19:23           ` Johannes Sixt
2009-12-08 14:01             ` Erik Faye-Lund
2009-11-26  0:59     ` [PATCH/RFC 02/11] strbuf: add non-variadic function strbuf_vaddf() Junio C Hamano
2009-11-26 10:38       ` Erik Faye-Lund
2009-11-26 11:13         ` Paolo Bonzini
2009-11-26 18:46         ` Junio C Hamano
2009-11-26 23:37           ` Erik Faye-Lund
2009-11-27  7:09             ` Johannes Sixt
2009-11-26  8:24   ` [PATCH/RFC 01/11] mingw: add network-wrappers for daemon Martin Storsjö
2009-11-26 10:43     ` [PATCH] Improve the mingw getaddrinfo stub to handle more use cases Martin Storsjö
2009-11-26 10:46     ` [PATCH/RFC 01/11] mingw: add network-wrappers for daemon Erik Faye-Lund
2009-11-26 11:03       ` Martin Storsjö
2009-12-02 13:01         ` Erik Faye-Lund
2009-12-02 13:21           ` Martin Storsjö
2009-12-02 13:49             ` Erik Faye-Lund
2009-12-02 15:11               ` Erik Faye-Lund
2009-12-02 19:34           ` Johannes Sixt
2009-11-26 20:04 ` [msysGit] [PATCH/RFC 00/11] daemon-win32 Johannes Sixt
  -- strict thread matches above, loose matches on Subject: below --
2009-11-26  0:39 Erik Faye-Lund
2009-11-26  0:39 ` [PATCH/RFC 01/11] mingw: add network-wrappers for daemon Erik Faye-Lund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259196260-3064-2-git-send-email-kusmabite@gmail.com \
    --to=kusmabite@googlemail.com \
    --cc=dotzenlabs@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kusmabite@gmail.com \
    --cc=msysgit@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).