From: Stephen Boyd <bebarino@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] reset: add --quiet option
Date: Sun, 29 Nov 2009 17:18:59 -0800 [thread overview]
Message-ID: <1259543939.5679.5.camel@swboyd-laptop> (raw)
In-Reply-To: <1259492290-21771-1-git-send-email-felipe.contreras@gmail.com>
On Sun, 2009-11-29 at 12:58 +0200, Felipe Contreras wrote:
> diff --git a/builtin-reset.c b/builtin-reset.c
> index 73e6022..c0127c4 100644
> --- a/builtin-reset.c
> +++ b/builtin-reset.c
> @@ -209,7 +209,7 @@ int cmd_reset(int argc, const char **argv, const char *prefix)
> "reset HEAD, index and working tree", HARD),
> OPT_SET_INT(0, "merge", &reset_type,
> "reset HEAD, index and working tree", MERGE),
> - OPT_BOOLEAN('q', NULL, &quiet,
> + OPT_BOOLEAN('q', "quiet", &quiet,
> "disable showing new HEAD in hard reset and progress message"),
> OPT_BOOLEAN('p', "patch", &patch_mode, "select hunks interactively"),
> OPT_END()
Why not just OPT__QUIET? We lose the specific help string but it's
possible that what quiet is silencing will change in the future.
Maybe you could move the help string to the documentation if you want to
save it.
next prev parent reply other threads:[~2009-11-30 1:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-29 10:58 [PATCH] reset: add --quiet option Felipe Contreras
2009-11-30 1:18 ` Stephen Boyd [this message]
2009-11-30 7:17 ` Junio C Hamano
2009-11-30 10:19 ` Felipe Contreras
2009-11-30 21:45 ` Stephen Boyd
2009-12-03 9:33 ` Felipe Contreras
2009-12-03 9:46 ` Stephen Boyd
2009-12-04 1:19 ` Junio C Hamano
2009-12-04 1:43 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259543939.5679.5.camel@swboyd-laptop \
--to=bebarino@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).