git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Herland <johan@herland.net>
To: git@vger.kernel.org
Cc: gitster@pobox.com, johan@herland.net, spearce@spearce.org
Subject: [RFC/PATCHv9 00/11] git notes
Date: Wed, 02 Dec 2009 03:09:32 +0100	[thread overview]
Message-ID: <1259719783-4674-1-git-send-email-johan@herland.net> (raw)

Hi,

Here is the 9th iteration of the git-notes series. Changes in this
iteration are as follows:

Changes to existing patches:

- Rebased back onto the early part of the jh/notes series, as
  suggested by Junio.

- Minor style fixes to some of the patches.

- The git-fast-import patch has been heavily rewritten after
  suggestions from Shawn. The new patch is much less intrusive,
  by way of NOT interfacing with the notes API, but doing the
  fanout strategy directly in fast-import.c instead.

- The new fast-import patch no longer depends on changes in the
  notes API. The fast-import-related patches are therefore moved
  to the head of the patch series, and the notes API changes that
  are no longer necessary (but still worthwhile, IMHO) are moved
  to the tail.

If Shawn is OK with the fast-import patch, I believe that at least
patches #1 - #3 (and possibly #4 - #5) are ready for 'next'.

Patches #6 - #11 drastically extend the notes API. Since there are
currently no users of that API, and it has not been discussed much
on the list (although these patches have already been present in a
couple of iterations), I would still consider them RFC quality.


TODO:
- Builtin-ify git-notes shell script to take advantage of notes API
- Garbage collect notes whose referenced object is unreachable (gc_notes())
- Handle note objects that are not blobs, but trees


Have fun! :)

...Johan


Johan Herland (11):
  fast-import: Proper notes tree manipulation
  Rename t9301 to t9350, to make room for more fast-import tests
  Add more testcases to test fast-import of notes
  Minor style fixes to notes.c
  Notes API: get_commit_notes() -> format_note() + remove the commit restriction
  Notes API: init_notes(): Initialize the notes tree from the given notes ref
  Notes API: add_note(): Add note objects to the internal notes tree structure
  Notes API: get_note(): Return the note annotating the given object
  Notes API: for_each_note(): Traverse the entire notes tree with a callback
  Notes API: Allow multiple concurrent notes trees with new struct notes_tree
  Refactor notes concatenation into a flexible interface for combining notes

 fast-import.c                                    |  141 +++++-
 notes.c                                          |  345 ++++++++++----
 notes.h                                          |  114 ++++-
 pretty.c                                         |    9 +-
 t/t9300-fast-import.sh                           |  156 ++++++-
 t/t9301-fast-import-notes.sh                     |  578 ++++++++++++++++++++++
 t/{t9301-fast-export.sh => t9350-fast-export.sh} |    0
 7 files changed, 1218 insertions(+), 125 deletions(-)
 create mode 100755 t/t9301-fast-import-notes.sh
 rename t/{t9301-fast-export.sh => t9350-fast-export.sh} (100%)

             reply	other threads:[~2009-12-02  2:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-02  2:09 Johan Herland [this message]
2009-12-02  2:09 ` [RFC/PATCHv9 01/11] fast-import: Proper notes tree manipulation Johan Herland
2009-12-02 20:39   ` Shawn O. Pearce
2009-12-02 22:41     ` Johan Herland
2009-12-03  3:45     ` Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 02/11] Rename t9301 to t9350, to make room for more fast-import tests Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 03/11] Add more testcases to test fast-import of notes Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 04/11] Minor style fixes to notes.c Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 05/11] Notes API: get_commit_notes() -> format_note() + remove the commit restriction Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 06/11] Notes API: init_notes(): Initialize the notes tree from the given notes ref Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 07/11] Notes API: add_note(): Add note objects to the internal notes tree structure Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 08/11] Notes API: get_note(): Return the note annotating the given object Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 09/11] Notes API: for_each_note(): Traverse the entire notes tree with a callback Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 10/11] Notes API: Allow multiple concurrent notes trees with new struct notes_tree Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 11/11] Refactor notes concatenation into a flexible interface for combining notes Johan Herland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259719783-4674-1-git-send-email-johan@herland.net \
    --to=johan@herland.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).