git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Herland <johan@herland.net>
To: git@vger.kernel.org
Cc: gitster@pobox.com, johan@herland.net, spearce@spearce.org
Subject: [RFC/PATCHv9 07/11] Notes API: add_note(): Add note objects to the internal notes tree structure
Date: Wed, 02 Dec 2009 03:09:39 +0100	[thread overview]
Message-ID: <1259719783-4674-8-git-send-email-johan@herland.net> (raw)
In-Reply-To: <1259719783-4674-1-git-send-email-johan@herland.net>

Signed-off-by: Johan Herland <johan@herland.net>
---
 notes.c |   11 +++++++++++
 notes.h |    4 ++++
 2 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/notes.c b/notes.c
index 23e62dd..3c8a6e0 100644
--- a/notes.c
+++ b/notes.c
@@ -366,6 +366,17 @@ void init_notes(const char *notes_ref, int flags)
 	load_subtree(&root_tree, &root_node, 0);
 }
 
+void add_note(const unsigned char *object_sha1, const unsigned char *note_sha1)
+{
+	struct leaf_node *l;
+
+	assert(initialized);
+	l = (struct leaf_node *) xmalloc(sizeof(struct leaf_node));
+	hashcpy(l->key_sha1, object_sha1);
+	hashcpy(l->val_sha1, note_sha1);
+	note_tree_insert(&root_node, 0, l, PTR_TYPE_NOTE);
+}
+
 static unsigned char *lookup_notes(const unsigned char *object_sha1)
 {
 	struct leaf_node *found = note_tree_find(&root_node, 0, object_sha1);
diff --git a/notes.h b/notes.h
index 6b52799..5f22852 100644
--- a/notes.h
+++ b/notes.h
@@ -21,6 +21,10 @@
  */
 void init_notes(const char *notes_ref, int flags);
 
+/* Add the given note object to the internal notes tree structure */
+void add_note(const unsigned char *object_sha1,
+		const unsigned char *note_sha1);
+
 /* Free (and de-initialize) the internal notes tree structure */
 void free_notes(void);
 
-- 
1.6.5.3.433.g11067

  parent reply	other threads:[~2009-12-02  2:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-02  2:09 [RFC/PATCHv9 00/11] git notes Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 01/11] fast-import: Proper notes tree manipulation Johan Herland
2009-12-02 20:39   ` Shawn O. Pearce
2009-12-02 22:41     ` Johan Herland
2009-12-03  3:45     ` Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 02/11] Rename t9301 to t9350, to make room for more fast-import tests Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 03/11] Add more testcases to test fast-import of notes Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 04/11] Minor style fixes to notes.c Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 05/11] Notes API: get_commit_notes() -> format_note() + remove the commit restriction Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 06/11] Notes API: init_notes(): Initialize the notes tree from the given notes ref Johan Herland
2009-12-02  2:09 ` Johan Herland [this message]
2009-12-02  2:09 ` [RFC/PATCHv9 08/11] Notes API: get_note(): Return the note annotating the given object Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 09/11] Notes API: for_each_note(): Traverse the entire notes tree with a callback Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 10/11] Notes API: Allow multiple concurrent notes trees with new struct notes_tree Johan Herland
2009-12-02  2:09 ` [RFC/PATCHv9 11/11] Refactor notes concatenation into a flexible interface for combining notes Johan Herland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259719783-4674-8-git-send-email-johan@herland.net \
    --to=johan@herland.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).