From: Sam Vilain <sam@vilain.net>
To: Alex Vandiver <alex@chmrr.net>
Cc: Eric Wong <normalperson@yhbt.net>, git <git@vger.kernel.org>
Subject: Re: [spf:guess] Re: [PATCH 2/5] git-svn: Make merge metadata accessible to make_log_entry
Date: Sun, 06 Dec 2009 11:59:32 +1300 [thread overview]
Message-ID: <1260053972.22680.5.camel@denix> (raw)
In-Reply-To: <1260052934-sup-9563@utwig>
On Sat, 2009-12-05 at 17:51 -0500, Alex Vandiver wrote:
> At Sat Dec 05 17:32:41 -0500 2009, Eric Wong wrote:
> > I'll continue to defer to Sam for ack-ing SVK-related things.
> >
> > One thing I am very picky about is wrapping lines at 80-columns or
> > less (hard tabs being 8 characters wide).
>
> *nod* I've fixed up my local copy for v2 to rewrap things at < 80
> columns, and will keep that in mind for the future.
Hi, I've just seen the series, looks like a good idea. Just a couple of
questions then I'll review the code;
- when a change is merged upstream with svk, you will get multiple log
entries in a single commit message. What do you do with commits like
that?
- there are quite a few repos which will have empty commits (ie, no
changes), but with one or more of the above log entries, owing to a bug
which I can't seem to find the details of right now.. how might those
appear?
Thanks for your submission!
Sam
next prev parent reply other threads:[~2009-12-05 22:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 19:07 [PATCH 0/5] git-svn: svk log message cleanup Alex Vandiver
2009-12-02 19:07 ` [PATCH 1/5] git-svn: Allow setting the committer and author date separately Alex Vandiver
2009-12-02 19:07 ` [PATCH 2/5] git-svn: Make merge metadata accessible to make_log_entry Alex Vandiver
2009-12-02 20:46 ` Alex Vandiver
2009-12-05 22:32 ` Eric Wong
2009-12-05 22:51 ` Alex Vandiver
2009-12-05 22:59 ` Sam Vilain [this message]
2009-12-05 23:10 ` [spf:guess] " Alex Vandiver
2009-12-19 22:24 ` Alex Vandiver
2009-12-02 19:07 ` [PATCH 3/5] git-svn: Strip SVK headers, optionally parsing author information Alex Vandiver
2009-12-02 19:07 ` [PATCH 4/5] git-svn: Provide a default "empty commit message" so the metadata is not the header Alex Vandiver
2009-12-02 19:07 ` [PATCH 5/5] git-svn: Correct a copy-and-pasted misleading comment Alex Vandiver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260053972.22680.5.camel@denix \
--to=sam@vilain.net \
--cc=alex@chmrr.net \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).