From: Alex Vandiver <alex@chmrr.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] Allow --quiet option to git remote, particularly for `git remote update`
Date: Mon, 07 Dec 2009 02:23:13 -0500 [thread overview]
Message-ID: <1260169742-sup-9991@utwig> (raw)
In-Reply-To: <7vd42soo2p.fsf@alter.siamese.dyndns.org>
At Sat Dec 05 21:04:14 -0500 2009, Junio C Hamano wrote:
> Alex Vandiver <alex@chmrr.net> writes:
> > ...
> > "git remote prune [-n | --dry-run] <name>",
> > - "git remote [-v | --verbose] update [-p | --prune] [group | remote]",
> > + "git remote [-v | --verbose] [-q | --quiet] update [-p | --prune] [group]",
Hm, I hadn't noticed that I'd changed "[group | remote]" to "[group]".
I think this is due to a mismerge on my part -- apologies. As another
data point, `git fetch` describes this as "[<repository> | <group>]".
> Three issues to consider:
>
> - shouldn't we use the same typography, i.e. <group>?
>
> - should we say <name> _if_ we are not going to say <group>|<remote>?
>
> - should we keep it as <group>|<remote> to make it clear that only this
> subcommand allows the group nickname?
>
> The first two are easy and I expect the answers to be both yes. The third
> one needs some studying and further thought.
>
> - is "remote update" the only one that takes group nickname?
My quick skim of the code says "yes" -- the other commands only deal
with single remotes at a time, and prune is oblivious to groups.
> - should "remote update" the only one? e.g. does "remote prune" also
> take group? if not, shouldn't it?
Properly, it "ought" to, though I don't see much utility over `git
remote fetch --prune groupname`. Probably at the same time, the
parallel pruning codepaths in builtin-fetch.c:prune_refs() and
builtin-remote.c:prune_remote() should be unified.
- Alex
--
Networking -- only one letter away from not working
next prev parent reply other threads:[~2009-12-07 7:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-06 0:00 [PATCH] Allow --quiet option to git remote, particularly for `git remote update` Alex Vandiver
2009-12-06 2:04 ` Junio C Hamano
2009-12-07 7:23 ` Alex Vandiver [this message]
2009-12-06 14:50 ` Jeff King
2009-12-07 6:15 ` Alex Vandiver
2009-12-07 6:40 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260169742-sup-9991@utwig \
--to=alex@chmrr.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).