From: Stephen Boyd <bebarino@gmail.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Stephan Beyer <s-beyer@gmx.net>,
Daniel Barkalow <barkalow@iabervon.org>,
Jakub Narebski <jnareb@gmail.com>,
Paolo Bonzini <bonzini@gnu.org>,
Johannes Sixt <j.sixt@viscovery.net>
Subject: Re: [PATCH v4 2/6] reset: use "unpack_trees()" directly instead of "git read-tree"
Date: Tue, 08 Dec 2009 00:45:19 -0800 [thread overview]
Message-ID: <1260261919.1554.11.camel@swboyd-laptop> (raw)
In-Reply-To: <20091208075616.4475.46720.chriscool@tuxfamily.org>
On Tue, 2009-12-08 at 08:56 +0100, Christian Couder wrote:
> +static int parse_and_init_tree_desc(const unsigned char *sha1,
> + struct tree_desc *desc)
> +{
> + struct tree *tree = parse_tree_indirect(sha1);
> + if (!tree)
> + return 1;
> + init_tree_desc(desc, tree->buffer, tree->size);
> + return 0;
> +}
> +
>
Is there a reason why you use this function instead of
fill_tree_descriptor()?
next prev parent reply other threads:[~2009-12-08 8:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 7:56 [PATCH v4 0/6] "git reset --merge" related improvements Christian Couder
2009-12-08 7:56 ` [PATCH v4 1/6] reset: add a few tests for "git reset --merge" Christian Couder
2009-12-08 7:56 ` [PATCH v4 2/6] reset: use "unpack_trees()" directly instead of "git read-tree" Christian Couder
2009-12-08 8:45 ` Stephen Boyd [this message]
2009-12-12 4:19 ` Christian Couder
2009-12-08 7:56 ` [PATCH v4 3/6] reset: add option "--keep-local-changes" to "git reset" Christian Couder
2009-12-08 7:56 ` [PATCH v4 4/6] reset: add test cases for "--keep-local-changes" option Christian Couder
2009-12-08 7:56 ` [PATCH v4 5/6] Documentation: reset: describe new " Christian Couder
2009-12-08 7:56 ` [PATCH v4 6/6] Documentation: reset: add some tables to describe the different options Christian Couder
2009-12-08 8:29 ` [PATCH v4 0/6] "git reset --merge" related improvements Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260261919.1554.11.camel@swboyd-laptop \
--to=bebarino@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=bonzini@gnu.org \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=jnareb@gmail.com \
--cc=s-beyer@gmx.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox