From: Sam Vilain <sam@vilain.net>
To: git@vger.kernel.org
Cc: Eric Wong <normalperson@yhbt.net>, Andrew Myrick <amyrick@gmail.com>
Subject: Re: [PATCH 2/5] git-svn: memoize conversion of SVN merge ticket info to git commit ranges
Date: Sun, 20 Dec 2009 05:37:38 +1300 [thread overview]
Message-ID: <1261240658.20752.5.camel@denix> (raw)
In-Reply-To: <1261240435-8948-3-git-send-email-sam@vilain.net>
On Sun, 2009-12-20 at 05:33 +1300, Sam Vilain wrote:
> Each time the svn mergeinfo ticket changes, we look it up in the rev_map;
> when there are a lot of merged branches, this will result in many repeated
> lookups of the same information for subsequent commits. Arrange the slow
> part of the function so that it may be memoized, and memoize it. The more
> expensive revision walking operation can be memoized separately.
Sorry, that text was an old revision. Read as:
Each time the svn mergeinfo ticket changes, we look it up in the
rev_map; when there are a lot of merged branches, this will result in
many repeated lookups of the same information for subsequent commits.
Arrange that part of the function so that it may be memoized, and
memoize it.
Sam
next prev parent reply other threads:[~2009-12-19 16:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-19 16:33 Efficiency and correctness patches for git-svn mergeinfo support Sam Vilain
2009-12-19 16:33 ` [PATCH 1/5] git-svn: expand the svn mergeinfo test suite, highlighting some failures Sam Vilain
2009-12-19 16:33 ` [PATCH 2/5] git-svn: memoize conversion of SVN merge ticket info to git commit ranges Sam Vilain
2009-12-19 16:33 ` [PATCH 3/5] git-svn: fix some mistakes with interpreting SVN mergeinfo " Sam Vilain
2009-12-19 16:33 ` [PATCH 4/5] git-svn: exclude already merged tips using one rev-list call Sam Vilain
2009-12-19 16:33 ` [PATCH 5/5] git-svn: detect cherry-picks correctly Sam Vilain
2009-12-19 16:37 ` Sam Vilain [this message]
2009-12-20 21:24 ` [PATCH 2/5] git-svn: memoize conversion of SVN merge ticket info to git commit ranges Sam Vilain
2009-12-21 10:44 ` Eric Wong
2009-12-19 16:42 ` Efficiency and correctness patches for git-svn mergeinfo support Sam Vilain
2009-12-19 22:15 ` Andrew Myrick
2009-12-20 21:07 ` Sam Vilain
2009-12-20 22:03 ` Andrew Myrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261240658.20752.5.camel@denix \
--to=sam@vilain.net \
--cc=amyrick@gmail.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).