git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Cc: John 'Warthog9' Hawley <warthog9@eaglescrag.net>,
	John 'Warthog9' Hawley <warthog9@kernel.org>,
	Jakub Narebski <jnareb@gmail.com>
Subject: [PATCHv3 0/4 (resent)] Miscelanous gitweb improvements from J.H.
Date: Sun,  3 Jan 2010 17:07:26 +0100	[thread overview]
Message-ID: <1262534850-24572-1-git-send-email-jnareb@gmail.com> (raw)

This is resend of early part of "[PATCH 0/6] Gitweb caching changes v2"
thread by John 'Warthog9' Hawley (J.H.),
  Message-ID: <1260488743-25855-1-git-send-email-warthog9@kernel.org>
  http://thread.gmane.org/gmane.comp.version-control.git/135052

or alternatively
  git://git.kernel.org/pub/scm/git/warthog9/gitweb.git gitweb-ml-v2

with a few modifications of my own.  Those patches were send originally as
responses in the mentioned thread, for further comments from original
author.  As the discussion didn't pick up (because of kernel.org upgrade, and
perhaps due to end-of-year stuff), I am resending those patches in a
separate thread for a better visibility; only comments are changed.

This series of patches is rebased on top of commit 37bae10
(Merge branch 'maint', 2009-12-31) in 'master' branch.


Change that apply to all patches in series: 
* moving from "GITWEB - " to "gitweb: " as subsystem prefix
* changing author to John 'Warthog9' Hawley <warthog9@kernel.org>
  (it was John 'Warthog9' Hawley <warthog9@eaglescrag.net>)
* add signoff or change it to John 'Warthog9' Hawley <warthog9@kernel.org>,
  and of course add my own signoff.


I have included reply to neither "GITWEB - File based caching layer"
nor "GITWEB - Separate defaults from main file" in this thread/series.

I haven't included the main point of the whole series, namely adding
response caching layer in the form that is used in git.kernel.org, because
I think this patch should be split into smaller parts, and unit-tested.
As it is now it is a bit of mess.  I have done patch which makes gitweb
always use explicit filehandle when printing (simplifying a bit it
replaces 'print <something>' by 'print {$out} <something>', with $out set
to \*STDOUT), as a patch that prepares for (optional) gitweb caching, while
not affecting throughput, latency and memory consumption when caching is
disabled, as opposed to original solution by J.H. of always storing whole
response in scalar and writing it at the end. 

I haven't included splitting of gitweb_defaults.perl off gitweb.perl, as it
was after large and invasive gitweb caching patch, it would require
substantial changes to gitweb tests upfront (by testing built gitweb.cgi and
not source gitweb.perl), and needs fixing of Makefile to actually work
reliably (we could have to process both gitweb.perl and
gitweb_defaults.perl, while provided Makefile process only the file which
triggered the rule... I think).


I am not sure if 'gitweb: Add option to force version match' is a good
solution to the problem it tires to address, i.e. if it is worth having, 
and I am not sure if I did 'gitweb: Makefile improvements' correctly.

John 'Warthog9' Hawley (4):
  gitweb: Load checking
  gitweb: Add option to force version match
  gitweb: Optionally add "git" links in project list page
  gitweb: Makefile improvements

 Makefile           |   65 +++++---------------------
 gitweb/Makefile    |  129 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 gitweb/README      |   14 +++++-
 gitweb/gitweb.perl |   80 ++++++++++++++++++++++++++++++--
 4 files changed, 230 insertions(+), 58 deletions(-)
 create mode 100644 gitweb/Makefile

John, any comments?

-- 
Jakub Narebski
ShadeHawk or jnareb on #git
Poland

             reply	other threads:[~2010-01-03 16:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-03 16:07 Jakub Narebski [this message]
2010-01-03 16:07 ` [PATCHv2 1/4 (resent)] gitweb: Load checking Jakub Narebski
2010-01-03 16:07 ` [RFC/PATCHv2 2/4 (resent)] gitweb: Add option to force version match Jakub Narebski
2010-01-03 16:07 ` [PATCHv3 3/4 (resent)] gitweb: Optionally add "git" links in project list page Jakub Narebski
     [not found]   ` <4B47E06C.9070503@eaglescrag.net>
2010-01-09 11:20     ` Jakub Narebski
2010-01-12  0:39       ` J.H.
2010-01-12 13:05         ` Jakub Narebski
2010-01-03 16:07 ` [PATCHv2/RFC 4/4 (resent)] gitweb: Makefile improvements Jakub Narebski
2010-01-06 22:28 ` [PATCHv3 0/4 (resent)] Miscelanous gitweb improvements from J.H J.H.
2010-01-06 23:22   ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1262534850-24572-1-git-send-email-jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=warthog9@eaglescrag.net \
    --cc=warthog9@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).