git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ident.c: suppress fprintf compiler warning
@ 2010-01-17  6:16 Tarmigan Casebolt
  0 siblings, 0 replies; only message in thread
From: Tarmigan Casebolt @ 2010-01-17  6:16 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git, Tarmigan Casebolt

Compiling today's pu gave
    ...
    CC ident.o
    CC levenshtein.o
ident.c: In function 'fmt_ident':
ident.c:206: warning: format not a string literal and no format arguments
    CC list-objects.o
    ...

This warning seems to have appeared first in 18e95f279ec6 (ident.c:
remove unused variables) which removed additional fprintf arguments.

Suppress this warning by using a literal "%s" to print the string
instead of passing the string directly to fprintf.

Signed-off-by: Tarmigan Casebolt <tarmigan+git@gmail.com>
---
 ident.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ident.c b/ident.c
index d4f6145..239112c 100644
--- a/ident.c
+++ b/ident.c
@@ -203,7 +203,7 @@ const char *fmt_ident(const char *name, const char *email,
 
 		if ((warn_on_no_name || error_on_no_name) &&
 		    name == git_default_name && env_hint) {
-			fprintf(stderr, env_hint);
+			fprintf(stderr, "%s", env_hint);
 			env_hint = NULL; /* warn only once */
 		}
 		if (error_on_no_name)
-- 
1.6.6.425.g6b174

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-01-17  6:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-17  6:16 [PATCH] ident.c: suppress fprintf compiler warning Tarmigan Casebolt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).