From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: [PATCH 0/2] @{u} updates
Date: Wed, 20 Jan 2010 01:38:40 -0800 [thread overview]
Message-ID: <1263980322-4142-1-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <7vwrzmqypn.fsf@alter.siamese.dyndns.org>
Earlier I wondered if the approach Dscho's patch takes to teach the new
@{upstream} syntax to substitute_branch_name() (hence dwim_ref()) without
teaching it to interpret_branch_name() (hence strbuf_branchname()) was a
bad idea. I thought about this a bit more; there are some downsides for
not doing so.
The first patch adds a handful of tests that show why strbuf_branchname()
callers may also want to learn about the new syntax. The second patch
moves the logic to interpret_branch_name() to make them happier.
The name of the key function was changed from tracked_suffix() to
upstream_mark(), not only because the syntax talks about @{upstream}, but
because the parsing needs to recognize the @{u}/@{upstream} mark at the
beginning of the given string (that is a suffix to some other string), and
strip it (the earlier code wanted @{u} to be at the very end but the
callers need to have it at the beginning).
Junio C Hamano (2):
t1506: more test for @{upstream} syntax
Teach @{upstream} syntax to strbuf_branchanme()
sha1_name.c | 116 ++++++++++++++++++++++++++---------------
t/t1506-rev-parse-upstream.sh | 41 ++++++++++++++
2 files changed, 115 insertions(+), 42 deletions(-)
next prev parent reply other threads:[~2010-01-20 9:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 18:49 default behaviour for `gitmerge` (no arguments) Gareth Adams
2010-01-11 19:43 ` Junio C Hamano
2010-01-12 16:23 ` Jeff King
2010-01-12 18:11 ` Junio C Hamano
2010-01-12 18:25 ` Jeff King
2010-01-13 6:57 ` Junio C Hamano
2010-01-13 9:26 ` Johannes Schindelin
2010-01-13 9:47 ` Junio C Hamano
2010-01-13 11:04 ` Johannes Schindelin
2010-01-13 19:48 ` Junio C Hamano
2010-01-13 22:49 ` Johannes Schindelin
2010-01-13 23:13 ` Junio C Hamano
2010-01-20 9:38 ` Junio C Hamano [this message]
2010-01-20 9:38 ` [PATCH 1/2] t1506: more test for @{upstream} syntax Junio C Hamano
2010-01-26 13:07 ` Jeff King
2010-01-26 19:58 ` Junio C Hamano
2010-01-27 10:24 ` Jeff King
2010-01-27 18:50 ` Junio C Hamano
2010-01-28 8:52 ` Jeff King
2010-01-26 21:32 ` Junio C Hamano
2010-01-27 11:40 ` Jeff King
2010-01-27 19:10 ` Junio C Hamano
2010-01-28 9:44 ` Jeff King
2010-01-28 9:50 ` [PATCH 1/3] test combinations of @{} syntax Jeff King
2010-01-28 9:52 ` [PATCH 2/3] fix parsing of @{-1}@{u} combination Jeff King
2010-01-28 9:56 ` [PATCH 3/3] reject @{-1} not at beginning of object name Jeff King
2010-01-28 20:02 ` Junio C Hamano
2010-01-29 11:22 ` Jeff King
2010-01-20 9:38 ` [PATCH 2/2] Teach @{upstream} syntax to strbuf_branchanme() Junio C Hamano
2010-01-20 13:08 ` [PATCH 0/2] @{u} updates Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263980322-4142-1-git-send-email-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).