* [PATCH] commit-tree: remove unused #define
@ 2010-01-25 7:05 Stephen Boyd
2010-01-25 9:17 ` Daniel
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Boyd @ 2010-01-25 7:05 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano
---
The fixme looks very suspicious too...
builtin-commit-tree.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/builtin-commit-tree.c b/builtin-commit-tree.c
index ddcb7a4..90dac34 100644
--- a/builtin-commit-tree.c
+++ b/builtin-commit-tree.c
@@ -9,8 +9,6 @@
#include "builtin.h"
#include "utf8.h"
-#define BLOCKING (1ul << 14)
-
/*
* FIXME! Share the code with "write-tree.c"
*/
--
1.6.6.1.436.gaba7d
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] commit-tree: remove unused #define
2010-01-25 7:05 [PATCH] commit-tree: remove unused #define Stephen Boyd
@ 2010-01-25 9:17 ` Daniel
0 siblings, 0 replies; 2+ messages in thread
From: Daniel @ 2010-01-25 9:17 UTC (permalink / raw)
To: git, Stephen Boyd; +Cc: Junio C Hamano
> ---
>
> The fixme looks very suspicious too...
According to git blame it belongs to the same revision as BLOCKING
-- initial commit. So probably it can be removed with BLOCKING.
>
> builtin-commit-tree.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/builtin-commit-tree.c b/builtin-commit-tree.c
> index ddcb7a4..90dac34 100644
> --- a/builtin-commit-tree.c
> +++ b/builtin-commit-tree.c
> @@ -9,8 +9,6 @@
> #include "builtin.h"
> #include "utf8.h"
>
> -#define BLOCKING (1ul << 14)
> -
> /*
> * FIXME! Share the code with "write-tree.c"
> */
> --
> 1.6.6.1.436.gaba7d
>
-- Daniel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-25 9:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-25 7:05 [PATCH] commit-tree: remove unused #define Stephen Boyd
2010-01-25 9:17 ` Daniel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).