git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Keith Whitwell <keithw@vmware.com>
To: tom fogal <tfogal@alumni.unh.edu>
Cc: Jose Fonseca <jfonseca@vmware.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>,
	mesa3d-dev <mesa3d-dev@lists.sourceforge.net>
Subject: Re: [Mesa3d-dev] mesa_7_7_branch -> master merges
Date: Tue, 26 Jan 2010 10:59:55 +0000	[thread overview]
Message-ID: <1264503595.18994.5.camel@toffee> (raw)
In-Reply-To: <auto-000021766217@sci.utah.edu>

On Mon, 2010-01-25 at 11:04 -0800, tom fogal wrote:
> I think we've touched on a core git workflow issue here, and its likely
> others have hit this && have a solution, so I've added the git ML to
> the CC list.
> 
> Git: the situation in this repo is a fast-moving master that is
> including many changes to internal interfaces.  Stable branches just
> get bugfixes, and are periodically merged to master.  However, the more
> the heads diverge, the more difficult it is for a bugfix to merge into
> the head.  The major issue is that more experienced developers should
> really weigh in on these merges, because they tend to automagically
> undo some of the interface changes.  Yet during such a delay, master
> inevitably moves, and the bugfixer has to do even more work to "redo"
> the merge (and potentially get more review!).
> 
> Of course, if there are two bugfixers trying to make separate changes
> in the same time period, this gets worse.
> 
> Is there a workflow that can solve this issue?
> 

Speaking from the Mesa side, I think part of our problem is that it's
not easy to build the entire mesa tree, which means that the developer
doing the merge cannot even compile-test the result, meaning that many
trivial failures go unnoticed.

I'd argue that if we had a maximal mesa build target that compiled
*everything*, regardless of whether it produced drivers or not, we'd
have a much better chance of catching bogus merge droppings.

Despite Jose's valid concerns, I'd still argue that the situation we
have now is superior to what came before - where people were supposed to
be cherry-picking bugfixes but more likely they were forgotten or it
fell on Brian's shoulders to do manually.

Keith

  reply	other threads:[~2010-01-26 11:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1264424650.3029.155.camel@jfonseca-laptop>
     [not found] ` <auto-000021765525@sci.utah.edu>
     [not found]   ` <1264443264.3029.255.camel@jfonseca-laptop>
2010-01-25 19:04     ` mesa_7_7_branch -> master merges tom fogal
2010-01-26 10:59       ` Keith Whitwell [this message]
2010-01-25 19:14 [Mesa3d-dev] " tom fogal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264503595.18994.5.camel@toffee \
    --to=keithw@vmware.com \
    --cc=git@vger.kernel.org \
    --cc=jfonseca@vmware.com \
    --cc=mesa3d-dev@lists.sourceforge.net \
    --cc=tfogal@alumni.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).