From: Brian Gernhardt <brian@gernhardtsoftware.com>
To: Jakub Narebski <jnareb@gmail.com>, Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>
Subject: [PATCH] t9501: Correctly force over max load everywhere
Date: Sat, 6 Feb 2010 09:50:03 -0500 [thread overview]
Message-ID: <1265467803-31210-1-git-send-email-brian@gernhardtsoftware.com> (raw)
In-Reply-To: <201002061505.13886.jnareb@gmail.com>
The code to check for load returns 0 if it doesn't know how to find
load. It also checks to see if the current load is higher than the
max load. So to force the script to quit early by setting the maxload
variable negative which should work for systems where we can detect
load (which should be a positive number) and systems where we can't
(where detected load is 0)
Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com>
---
Tested and works.
t/t9501-gitweb-standalone-http-status.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t9501-gitweb-standalone-http-status.sh b/t/t9501-gitweb-standalone-http-status.sh
index 7590f10..d196cc5 100755
--- a/t/t9501-gitweb-standalone-http-status.sh
+++ b/t/t9501-gitweb-standalone-http-status.sh
@@ -117,7 +117,7 @@ test_debug 'cat gitweb.output'
# always hit the load limit
cat >>gitweb_config.perl <<\EOF
-our $maxload = 0;
+our $maxload = -1;
EOF
test_expect_success 'load checking: load too high (default action)' '
--
1.7.0.rc1.205.g52ece
next prev parent reply other threads:[~2010-02-06 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-06 5:00 [PATCH] t9501: Skip testing load if we can't detect it Brian Gernhardt
2010-02-06 11:22 ` Jakub Narebski
2010-02-06 13:46 ` Brian Gernhardt
2010-02-06 14:05 ` Jakub Narebski
2010-02-06 14:50 ` Brian Gernhardt [this message]
2010-02-06 19:45 ` [PATCH] t9501: Correctly force over max load everywhere Jakub Narebski
2010-02-06 18:31 ` [PATCH] t9501: Skip testing load if we can't detect it Junio C Hamano
2010-02-06 20:09 ` Brian Gernhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265467803-31210-1-git-send-email-brian@gernhardtsoftware.com \
--to=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).