From: Pavel Roskin <proski@gnu.org>
To: Alex Chiang <achiang@hp.com>
Cc: git@vger.kernel.org
Subject: Current stgit asks SMTP password for every patch
Date: Sat, 06 Feb 2010 21:18:30 -0500 [thread overview]
Message-ID: <1265509110.10712.22.camel@mj> (raw)
Hello, Alex!
I was unpleasantly surprised when the current STGit started asking me
for the SMTP password for every patch in the series:
$ stg mail --to minicom ncurses-const..clobber
Checking the validity of the patches ... done
Sending patch "ncurses-const" ... Please enter SMTP password:
done
Sending patch "precision-int" ... Please enter SMTP password:
done
Sending patch "aliasing" ... Please enter SMTP password:
done
Sending patch "clobber" ... Please enter SMTP password:
done
The code in __send_message_smtp() lacks any caching for the smtppassword
variable. The code comes from your commit
89d7ec43e0b25cc6cbc9feb044d7ce7048f224eb
stg mail: Refactor __send_message and friends
Ideally, asking for the password (as well as other verification of the
e-mail credentials) should be done before "Sending patch" is shown, and
before the cover letter if any. That is, it should be in func() in
stgit/commands/mail.py.
But I'll also be fine with a simple-minded password caching in
__send_message_smtp().
--
Regards,
Pavel Roskin
reply other threads:[~2010-02-07 2:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265509110.10712.22.camel@mj \
--to=proski@gnu.org \
--cc=achiang@hp.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).