From: "Stefan-W. Hahn" <stefan.hahn@s-hahn.de>
To: git@vger.kernel.org
Cc: "Stefan-W. Hahn" <stefan.hahn@s-hahn.de>
Subject: [PATCH 3/4] git-am: Add command line parameter `--keep-cr` passing it to git-mailsplit.
Date: Thu, 11 Feb 2010 22:26:18 +0100 [thread overview]
Message-ID: <1265923579-24900-4-git-send-email-stefan.hahn@s-hahn.de> (raw)
In-Reply-To: <1265923579-24900-1-git-send-email-stefan.hahn@s-hahn.de>
If applying patches with the following command sequence
git format-patch --stdout ... | git am ...
in repositories having files with dos and unix line endings
git-mailsplit, which is called from git-am must be called with
`--keep-cr` parameter since commit c2ca1d79.
This patch adds the command line parameter `--keep-cr` for git-am.
Signed-off-by: Stefan-W. Hahn <stefan.hahn@s-hahn.de>
---
git-am.sh | 18 ++++++++++++++----
1 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/git-am.sh b/git-am.sh
index c8b9cbb..c3101ae 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -15,6 +15,7 @@ q,quiet be quiet
s,signoff add a Signed-off-by line to the commit message
u,utf8 recode into utf8 (default)
k,keep pass -k flag to git-mailinfo
+e,keep-cr pass --keep-cr flag to git-mailsplit for mbox format
c,scissors strip everything before a scissors line
whitespace= pass it through git-apply
ignore-space-change pass it through git-apply
@@ -216,10 +217,12 @@ check_patch_format () {
split_patches () {
case "$patch_format" in
mbox)
- case "$rebasing" in
- '')
+ case "$rebasing,$keepcr" in
+ '','')
keep_cr= ;;
- ?*)
+ '',t)
+ keep_cr=--keep-cr ;;
+ ?*,t)
keep_cr=--keep-cr ;;
esac
git mailsplit -d"$prec" -o"$dotest" -b $keep_cr -- "$@" > "$dotest/last" ||
@@ -290,7 +293,7 @@ split_patches () {
prec=4
dotest="$GIT_DIR/rebase-apply"
-sign= utf8=t keep= skip= interactive= resolved= rebasing= abort=
+sign= utf8=t keep= keepcr= skip= interactive= resolved= rebasing= abort=
resolvemsg= resume= scissors= no_inbody_headers=
git_apply_opt=
committer_date_is_author_date=
@@ -347,6 +350,8 @@ do
allow_rerere_autoupdate="$1" ;;
-q|--quiet)
GIT_QUIET=t ;;
+ -e|--keep-cr)
+ keepcr=t ;;
--)
shift; break ;;
*)
@@ -452,6 +457,7 @@ else
echo "$sign" >"$dotest/sign"
echo "$utf8" >"$dotest/utf8"
echo "$keep" >"$dotest/keep"
+ echo "$keepcr" >"$dotest/keepcr"
echo "$scissors" >"$dotest/scissors"
echo "$no_inbody_headers" >"$dotest/no_inbody_headers"
echo "$GIT_QUIET" >"$dotest/quiet"
@@ -495,6 +501,10 @@ if test "$(cat "$dotest/keep")" = t
then
keep=-k
fi
+if test "$(cat "$dotest/keepcr")" = t
+then
+ keepcr=--keep-cr
+fi
case "$(cat "$dotest/scissors")" in
t)
scissors=--scissors ;;
--
1.7.0.rc2.17.g39385
next prev parent reply other threads:[~2010-02-11 21:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 21:26 [PATCHv2 0/4] Using git-mailsplit in mixed line ending environment Stefan-W. Hahn
2010-02-11 21:26 ` [PATCH 1/4] git-mailsplit: Show parameter '--keep-cr' in usage and documentation Stefan-W. Hahn
2010-02-11 21:26 ` [PATCH 2/4] git-mailsplit: add `mailsplit.keepcr` configuration variable Stefan-W. Hahn
2010-02-11 23:21 ` Junio C Hamano
2010-02-12 21:03 ` Stefan-W. Hahn
2010-02-12 21:49 ` Junio C Hamano
2010-02-12 22:00 ` Junio C Hamano
2010-02-12 22:04 ` Stefan-W. Hahn
2010-02-11 21:26 ` Stefan-W. Hahn [this message]
2010-02-11 23:21 ` [PATCH 3/4] git-am: Add command line parameter `--keep-cr` passing it to git-mailsplit Junio C Hamano
2010-02-12 21:05 ` Stefan-W. Hahn
2010-02-12 21:54 ` Junio C Hamano
2010-02-11 21:26 ` [PATCH 4/4] Adding test for `--keep-cr` for git-mailsplit and git-am Stefan-W. Hahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265923579-24900-4-git-send-email-stefan.hahn@s-hahn.de \
--to=stefan.hahn@s-hahn.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).