From: Erik Faye-Lund <kusmabite@googlemail.com>
To: git@vger.kernel.org
Cc: johannes.schindelin@gmx.de, normalperson@yhbt.net,
Erik Faye-Lund <kusmabite@gmail.com>
Subject: [PATCH 1/2] hash-object: support --stdin-paths with --no-filters
Date: Fri, 12 Feb 2010 18:52:34 +0100 [thread overview]
Message-ID: <1265997155-3592-1-git-send-email-kusmabite@gmail.com> (raw)
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---
builtin-hash-object.c | 8 ++++----
t/t1007-hash-object.sh | 4 ----
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/builtin-hash-object.c b/builtin-hash-object.c
index 6a5f5b5..080af1a 100644
--- a/builtin-hash-object.c
+++ b/builtin-hash-object.c
@@ -33,6 +33,8 @@ static void hash_object(const char *path, const char *type, int write_object,
hash_fd(fd, type, write_object, vpath);
}
+static int no_filters;
+
static void hash_stdin_paths(const char *type, int write_objects)
{
struct strbuf buf = STRBUF_INIT, nbuf = STRBUF_INIT;
@@ -44,7 +46,8 @@ static void hash_stdin_paths(const char *type, int write_objects)
die("line is badly quoted");
strbuf_swap(&buf, &nbuf);
}
- hash_object(buf.buf, type, write_objects, buf.buf);
+ hash_object(buf.buf, type, write_objects,
+ no_filters ? NULL : buf.buf);
}
strbuf_release(&buf);
strbuf_release(&nbuf);
@@ -60,7 +63,6 @@ static const char *type;
static int write_object;
static int hashstdin;
static int stdin_paths;
-static int no_filters;
static const char *vpath;
static const struct option hash_object_options[] = {
@@ -100,8 +102,6 @@ int cmd_hash_object(int argc, const char **argv, const char *prefix)
errstr = "Can't specify files with --stdin-paths";
else if (vpath)
errstr = "Can't use --stdin-paths with --path";
- else if (no_filters)
- errstr = "Can't use --stdin-paths with --no-filters";
}
else {
if (hashstdin > 1)
diff --git a/t/t1007-hash-object.sh b/t/t1007-hash-object.sh
index fd98e44..1509fe3 100755
--- a/t/t1007-hash-object.sh
+++ b/t/t1007-hash-object.sh
@@ -65,10 +65,6 @@ test_expect_success "Can't use --path with --stdin-paths" '
echo example | test_must_fail git hash-object --stdin-paths --path=foo
'
-test_expect_success "Can't use --stdin-paths with --no-filters" '
- echo example | test_must_fail git hash-object --stdin-paths --no-filters
-'
-
test_expect_success "Can't use --path with --no-filters" '
test_must_fail git hash-object --no-filters --path=foo
'
--
1.7.0.rc2
next reply other threads:[~2010-02-12 17:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 17:52 Erik Faye-Lund [this message]
2010-02-12 17:52 ` [PATCH 2/2] git-svn: support fetch with autocrlf on Erik Faye-Lund
2010-02-13 12:25 ` Eric Wong
2010-02-13 14:16 ` Erik Faye-Lund
2010-02-13 23:59 ` Johannes Schindelin
2010-02-14 0:27 ` Erik Faye-Lund
2010-02-14 0:46 ` Johannes Schindelin
2010-02-14 1:04 ` Erik Faye-Lund
2010-02-13 23:55 ` Johannes Schindelin
2010-02-12 18:37 ` [PATCH 1/2] hash-object: support --stdin-paths with --no-filters Dmitry Potapov
2010-02-14 13:42 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265997155-3592-1-git-send-email-kusmabite@gmail.com \
--to=kusmabite@googlemail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=kusmabite@gmail.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).