git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tay Ray Chuan <rctay89@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: "Jeff King" <peff@peff.net>,
	"Sebastian Thiel" <byronimo@gmail.com>,
	"Junio C Hamano" <gitster@pobox.com>
Subject: [PATCH 08/10] fetch: learn --progress
Date: Thu, 18 Feb 2010 20:37:09 +0800	[thread overview]
Message-ID: <1266496631-3980-9-git-send-email-rctay89@gmail.com> (raw)
In-Reply-To: <1266496631-3980-1-git-send-email-rctay89@gmail.com>

Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
---
 Documentation/fetch-options.txt |    9 ++++++++-
 builtin-fetch.c                 |    4 +++-
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/Documentation/fetch-options.txt b/Documentation/fetch-options.txt
index 83606f4..db1ea25 100644
--- a/Documentation/fetch-options.txt
+++ b/Documentation/fetch-options.txt
@@ -77,8 +77,15 @@ endif::git-pull[]
 -q::
 --quiet::
 	Pass --quiet to git-fetch-pack and silence any other internally
-	used git commands.
+	used git commands. Progress is not reported to the standard error
+	stream.
 
 -v::
 --verbose::
 	Be verbose.
+
+--progress::
+	Progress status is reported on the standard error stream
+	by default when it is attached to a terminal, unless -q
+	is specified. This flag forces progress status even if the
+	standard error stream is not directed to a terminal.
diff --git a/builtin-fetch.c b/builtin-fetch.c
index 6b96b41..7f9f669 100644
--- a/builtin-fetch.c
+++ b/builtin-fetch.c
@@ -27,6 +27,7 @@ enum {
 };
 
 static int all, append, dry_run, force, keep, multiple, prune, update_head_ok, verbosity;
+static int progress;
 static int tags = TAGS_DEFAULT;
 static const char *depth;
 static const char *upload_pack;
@@ -56,6 +57,7 @@ static struct option builtin_fetch_options[] = {
 	OPT_BOOLEAN('k', "keep", &keep, "keep downloaded pack"),
 	OPT_BOOLEAN('u', "update-head-ok", &update_head_ok,
 		    "allow updating of HEAD ref"),
+	OPT_BOOLEAN(0, "progress", &progress, "force progress reporting"),
 	OPT_STRING(0, "depth", &depth, "DEPTH",
 		   "deepen history of shallow clone"),
 	OPT_END()
@@ -823,7 +825,7 @@ static int fetch_one(struct remote *remote, int argc, const char **argv)
 		die("Where do you want to fetch from today?");
 
 	transport = transport_get(remote, NULL);
-	transport_set_verbosity(transport, verbosity, 0);
+	transport_set_verbosity(transport, verbosity, progress);
 	if (upload_pack)
 		set_option(TRANS_OPT_UPLOADPACK, upload_pack);
 	if (keep)
-- 
1.7.0.27.g5d71b

  parent reply	other threads:[~2010-02-18 12:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-18 12:37 [PATCH 00/10] teach --progress to transport-related builtins Tay Ray Chuan
2010-02-18 12:37 ` [PATCH 01/10] Documentation/git-pull.txt: mention --quiet and --verbose for fetching Tay Ray Chuan
2010-02-18 21:11   ` Junio C Hamano
2010-02-19  6:31     ` Tay Ray Chuan
2010-02-18 12:37 ` [PATCH 02/10] Documentation/git-push.txt: put --quiet before --verbose Tay Ray Chuan
2010-02-18 12:37 ` [PATCH 03/10] fetch: refactor verbosity option handling into transport.[ch] Tay Ray Chuan
2010-02-18 12:37 ` [PATCH 04/10] push: support multiple levels of verbosity Tay Ray Chuan
2010-02-18 12:37 ` [PATCH 05/10] clone: " Tay Ray Chuan
2010-02-18 12:37 ` [PATCH 06/10] transport->progress: use flag authoritatively Tay Ray Chuan
2010-02-18 12:37 ` [PATCH 07/10] push: learn --progress Tay Ray Chuan
2010-02-18 12:37 ` Tay Ray Chuan [this message]
2010-02-18 12:37 ` [PATCH 09/10] pull: " Tay Ray Chuan
2010-02-18 12:37 ` [PATCH 10/10] transport: update flags to be in running order Tay Ray Chuan
2010-02-19  1:26 ` [PATCH 00/10] teach --progress to transport-related builtins Junio C Hamano
2010-02-19  6:31   ` Tay Ray Chuan
2010-02-19  7:53     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266496631-3980-9-git-send-email-rctay89@gmail.com \
    --to=rctay89@gmail.com \
    --cc=byronimo@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).