From: Tuomas Suutari <tuomas.suutari@gmail.com>
To: git@vger.kernel.org
Cc: Tuomas Suutari <tuomas.suutari@gmail.com>,
Sam Vilain <sam@vilain.net>, Eric Wong <normalperson@yhbt.net>
Subject: [PATCH 1/2] git-svn: Fix merge detecting with rewrite-root
Date: Wed, 24 Feb 2010 20:09:01 +0200 [thread overview]
Message-ID: <1267034942-31581-1-git-send-email-tuomas.suutari@gmail.com> (raw)
Detecting of merges from svn:mergeinfo or svk merge tickets failed
with rewrite-root option. This fixes it.
Signed-off-by: Tuomas Suutari <tuomas.suutari@gmail.com>
---
Hi again,
now I found another problem while importing SVN repo with git-svn.
To speed-up the import, I copied the SVN repo with rsync to localhost
and used file:// URL for the import, but because I want to be able to
track the history with svn+ssh:// later, I used the rewrite-root
option. That seemed to break the merge detecting.
With this patch the merge detecting works also with rewrite-root
option, but since there are no comments why the $self->rewrite_root
was used in the first place, I have no idea, if this is the right
thing to do.
git-svn.perl | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 265852f..1cbddca 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -2993,7 +2993,7 @@ sub find_extra_svk_parents {
for my $ticket ( @tickets ) {
my ($uuid, $path, $rev) = split /:/, $ticket;
if ( $uuid eq $self->ra_uuid ) {
- my $url = $self->rewrite_root || $self->{url};
+ my $url = $self->{url};
my $repos_root = $url;
my $branch_from = $path;
$branch_from =~ s{^/}{};
@@ -3201,7 +3201,7 @@ sub find_extra_svn_parents {
# are now marked as merge, we can add the tip as a parent.
my @merges = split "\n", $mergeinfo;
my @merge_tips;
- my $url = $self->rewrite_root || $self->{url};
+ my $url = $self->{url};
my $uuid = $self->ra_uuid;
my %ranges;
for my $merge ( @merges ) {
--
1.7.0.2.ged48
next reply other threads:[~2010-02-24 18:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 18:09 Tuomas Suutari [this message]
2010-02-24 18:09 ` [PATCH 2/2] t9150,t9151: Add rewrite-root option to init Tuomas Suutari
2010-02-26 9:43 ` [PATCH 1/2] git-svn: Fix merge detecting with rewrite-root Eric Wong
2010-03-13 6:54 ` Tuomas Suutari
2010-03-13 8:44 ` Sam Vilain
2010-03-13 9:43 ` Eric Wong
2010-03-13 20:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267034942-31581-1-git-send-email-tuomas.suutari@gmail.com \
--to=tuomas.suutari@gmail.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=sam@vilain.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).