git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tay Ray Chuan <rctay89@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Clemens Buchacher" <drizzd@aon.at>,
	"Mike Hommey" <mh@glandium.org>
Subject: [PATCH v2 6/7] remote-curl: use http_fetch_ref() instead of walker wrapper
Date: Tue,  2 Mar 2010 18:49:30 +0800	[thread overview]
Message-ID: <1267526971-5552-7-git-send-email-rctay89@gmail.com> (raw)
In-Reply-To: <1267526971-5552-1-git-send-email-rctay89@gmail.com>

The http-walker implementation of walker->fetch_ref() doesn't do
anything special compared to http_fetch_ref() anyway.

Remove init_walker() invocation before fetching the ref, since we aren't
using the walker wrapper and don't need a walker instance anymore.

Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
---
 remote-curl.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/remote-curl.c b/remote-curl.c
index 1e13fb5..5ace99e 100644
--- a/remote-curl.c
+++ b/remote-curl.c
@@ -250,9 +250,8 @@ static struct ref *parse_info_refs(struct discovery *heads)
 		i++;
 	}
 
-	init_walker();
 	ref = alloc_ref("HEAD");
-	if (!walker->fetch_ref(walker, ref) &&
+	if (!http_fetch_ref(url, ref) &&
 	    !resolve_remote_symref(ref, refs)) {
 		ref->next = refs;
 		refs = ref;
-- 
1.7.0.26.gbfa16

  parent reply	other threads:[~2010-03-02 10:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-02 10:49 [PATCH v2 0/7] http: minor improvements Tay Ray Chuan
2010-03-02 10:49 ` [PATCH v2 1/7] t5541-http-push: check that ref is unchanged for non-ff test Tay Ray Chuan
2010-03-02 10:49 ` [PATCH v2 2/7] t554[01]-http-push: refactor, add non-ff tests Tay Ray Chuan
2010-03-02 10:49 ` [PATCH v2 3/7] http-push: remove "|| 1" to enable verbose check Tay Ray Chuan
2010-03-02 10:49 ` [PATCH v2 4/7] http-walker: cleanup more thoroughly Tay Ray Chuan
2010-03-02 10:49 ` [PATCH v2 5/7] http: init and cleanup separately from http-walker Tay Ray Chuan
2010-03-02 10:49 ` Tay Ray Chuan [this message]
2010-03-02 10:49 ` [PATCH v2 7/7] remote-curl: init walker only when needed Tay Ray Chuan
2010-03-04 20:38 ` [PATCH v2 0/7] http: minor improvements Clemens Buchacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1267526971-5552-7-git-send-email-rctay89@gmail.com \
    --to=rctay89@gmail.com \
    --cc=drizzd@aon.at \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mh@glandium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).