From: Matthieu Moy <Matthieu.Moy@imag.fr>
To: git@vger.kernel.org, gitster@pobox.com
Cc: Thomas Singer <thomas.singer@syntevo.com>,
Matthieu Moy <Matthieu.Moy@imag.fr>
Subject: [PATCH] stash: suggest the correct command line for unknown options.
Date: Fri, 5 Mar 2010 17:14:53 +0100 [thread overview]
Message-ID: <1267805693-25206-1-git-send-email-Matthieu.Moy@imag.fr> (raw)
In-Reply-To: <4B910736.7060604@syntevo.com>
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
> > Does SmartGit call 'git stash save' behind the scenes with the
> > user-supplied message? Then it should run
> >
> > git stash save -- "$msg"
> >
> > and you don't need to forbid anything.
>
> Thank you very much, this solved the problem.
... unless one considers that the problem is that you had to ask.
Something like this should avoid others the problem.
git-stash.sh | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-stash.sh b/git-stash.sh
index 2d69196..cf4e673 100755
--- a/git-stash.sh
+++ b/git-stash.sh
@@ -151,6 +151,7 @@ save_stash () {
;;
-*)
echo "error: unknown option for 'stash save': $1"
+ echo " To provide a message, use 'git stash -- $1'."
usage
;;
*)
--
1.7.0.231.g9fa6.dirty
next prev parent reply other threads:[~2010-03-05 16:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-05 12:16 git stash save <message> Thomas Singer
2010-03-05 12:55 ` Johannes Sixt
2010-03-05 13:29 ` Thomas Singer
2010-03-05 16:14 ` Matthieu Moy [this message]
2010-03-05 17:08 ` [PATCH] stash: suggest the correct command line for unknown options Jeff King
2010-03-05 18:43 ` [PATCH v2] " Matthieu Moy
2010-03-07 4:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267805693-25206-1-git-send-email-Matthieu.Moy@imag.fr \
--to=matthieu.moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=thomas.singer@syntevo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).