From: Mark Lodato <lodatom@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Mark Lodato <lodatom@gmail.com>
Subject: [PATCHv2 0/3] grep color enhancements
Date: Sun, 7 Mar 2010 11:52:44 -0500 [thread overview]
Message-ID: <1267980767-12617-1-git-send-email-lodatom@gmail.com> (raw)
This is a re-spin of the second half of Gmane 141186, "color
enhancements, particularly for grep", which is currently in pu as
'ml/color-grep'. The following changes were made, all to the second
patch:
* Fix the parsing of color.grep. The old code caused a segfault if this
option was set, and it also disallowed setting this option without
a value.
* Color the filename in --name-only output. I still don't like this,
but I understand that makes the coloring more consistent. As Junio
said, if there's no strong argument one way or the other, it's
probably best to follow GNU's lead.
* Style changes: Remove the cast to int for "rm_eo - rm_so", put else
on same line as curly brace, and remove an unnecessary variable
assignment.
* Asciidoc fixes: Use ";;" instead of ":::" for nested lists, and
un-indent the last sentence for color.grep.<slot>.
Mark Lodato (3):
Add GIT_COLOR_BOLD_* and GIT_COLOR_BG_*
grep: Colorize filename, line number, and separator
grep: Colorize selected, context, and function lines
Documentation/config.txt | 26 ++++++++++++++++--
builtin-grep.c | 38 +++++++++++++++++++++-----
color.h | 11 +++++++
graph.c | 12 ++++----
grep.c | 66 ++++++++++++++++++++++++++++++----------------
grep.h | 6 ++++
6 files changed, 119 insertions(+), 40 deletions(-)
next reply other threads:[~2010-03-07 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-07 16:52 Mark Lodato [this message]
2010-03-07 16:52 ` [PATCHv2 1/3] Add GIT_COLOR_BOLD_* and GIT_COLOR_BG_* Mark Lodato
2010-03-07 16:52 ` [PATCHv2 2/3] grep: Colorize filename, line number, and separator Mark Lodato
2010-03-07 19:02 ` Junio C Hamano
2010-03-07 20:47 ` Mark Lodato
2010-03-07 16:52 ` [PATCHv2 3/3] grep: Colorize selected, context, and function lines Mark Lodato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267980767-12617-1-git-send-email-lodatom@gmail.com \
--to=lodatom@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).