wishlist: git send-email improvement

wishlist: git send-email improvement

[Yann Droneaud]

Hi,

Here's a little wishlist for send-email

- Use From: field extracted from patch:
  If there's no configuration for user.email and From: field is 
  different than default auto generated From: address, 
  git send-email should use the one in the patch as default.

- Use To: field extracted from patch
  I've setup format-patch to add a default To: field with
  format.headers="To: xxx@yyy". But git send-email did not use it and 
  ask for a To: value.
  If there's no --to or sendmail.to, send-email should use To: value 
  extracted from patch and ask for user confirmation.

I've tried to add the later to git-send-email, but failed to fix it by
now in a reasonable time amount.

Regards.

-- 
Yann Droneaud

Re: wishlist: git send-email improvement

[Junio C Hamano]

Yann Droneaud <yann@droneaud.fr> writes:

> Here's a little wishlist for send-email
>
> - Use From: field extracted from patch:
>   If there's no configuration for user.email and From: field is 
>   different than default auto generated From: address, 
>   git send-email should use the one in the patch as default.

I cannot judge how sensible this change is; please justify the motivation
by adding "it currently does _this_, which is not good for _such and such
reasons_; instead" between the third and the fourth line.

> - Use To: field extracted from patch
>   I've setup format-patch to add a default To: field with
>   format.headers="To: xxx@yyy". But git send-email did not use it and 
>   ask for a To: value.
>   If there's no --to or sendmail.to, send-email should use To: value 
>   extracted from patch and ask for user confirmation.

With the recent addition of format.to that is cooking somewhere, I think
this one is probably sensible.

Re: wishlist: git send-email improvement

[Yann Droneaud]

Le mardi 09 mars 2010 à 09:30 -0800, Junio C Hamano a écrit :
> Yann Droneaud <yann@droneaud.fr> writes:
> 
> > Here's a little wishlist for send-email
> >
> > - Use From: field extracted from patch:
> >   If there's no configuration for user.email and From: field is 
> >   different than default auto generated From: address, 
> >   git send-email should use the one in the patch as default.
> 
> I cannot judge how sensible this change is; please justify the motivation
> by adding "it currently does _this_, which is not good for _such and such
> reasons_; instead" between the third and the fourth line.
> 

Sometimes, i'm too lazy to setup a valid git config user.email, 
so i'm commiting with a default, broken author name which get used later
by git format-patch to fill the From: field. 
Each time I'm doing this, I'm manually fixing the From: field in the
mbox file, hoping it will be used by git send-email, and each time I'm
disappointing to see git send-email use the broken author name as
default value.
Obviously, the proper fix would be for me to remember to set up git
config user.email before issuing any command ... but the so-called human
nature tells me it's definitely not my fault, the tool get it wrong and
should be fixed :) 
Perhaps I should learn to use git send-email --from instead.

> > - Use To: field extracted from patch
> >   I've setup format-patch to add a default To: field with
> >   format.headers="To: xxx@yyy". But git send-email did not use it and 
> >   ask for a To: value.
> >   If there's no --to or sendmail.to, send-email should use To: value 
> >   extracted from patch and ask for user confirmation.
> 
> With the recent addition of format.to that is cooking somewhere, I think
> this one is probably sensible.

Great.

Thanks for your time.

-- 
Yann Droneaud

Re: wishlist: git send-email improvement

[Yann Droneaud]

Le mardi 09 mars 2010 à 18:49 +0100, Yann Droneaud a écrit :
> Perhaps I should learn to use git send-email --from instead.

Sadly, it appends the From: field extracted from file to the Cc: list :/

So I still have to manually fix the mbox file before using git
send-email.

Regards.

-- 
Yann Droneaud

Re: wishlist: git send-email improvement

["L. Alberto Giménez"]

On 03/09/2010 06:55 PM, Yann Droneaud wrote:
> Le mardi 09 mars 2010 à 18:49 +0100, Yann Droneaud a écrit :
>> Perhaps I should learn to use git send-email --from instead.
> 
> Sadly, it appends the From: field extracted from file to the Cc: list :/
> 
> So I still have to manually fix the mbox file before using git
> send-email.

Hi,

Have you tried --suppress-from?

--[no-]suppress-from
           If this is set, do not add the From: address to the cc: list.
Default is the value of sendemail.suppressfrom configuration value; if
that is
           unspecified, default to --no-suppress-from.

I'm not sure if it's what you need, but it seems to be.


Best regards,
-- 
L. Alberto Giménez
GnuPG key ID 0x3BAABDE1

-- 
L. Alberto Giménez
GnuPG key ID 0x3BAABDE1

Re: wishlist: git send-email improvement

[Yann Droneaud]

Le mardi 09 mars 2010 à 20:30 +0100, "L. Alberto Giménez" a écrit :
> On 03/09/2010 06:55 PM, Yann Droneaud wrote:
> > Le mardi 09 mars 2010 à 18:49 +0100, Yann Droneaud a écrit :
> >> Perhaps I should learn to use git send-email --from instead.
> > 
> > Sadly, it appends the From: field extracted from file to the Cc: list :/
> > 
> > So I still have to manually fix the mbox file before using git
> > send-email.
> 
> Hi,
> 
> Have you tried --suppress-from?
> 
[...]
> I'm not sure if it's what you need, but it seems to be.
> 

Tested and approved. 
Thanks for the trick.

Regards.

-- 
Yann Droneaud