From: Sverre Rabbelier <srabbelier@gmail.com>
To: Git List <git@vger.kernel.org>,
Daniel Barkalow <barkalow@iabervon.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Martin Waitz <tali@admingilde.org>,
"Junio C Hamano" <gitst
Cc: Sverre Rabbelier <srabbelier@gmail.com>
Subject: [PATCH 2/2] clone: pass the remote name to remote_get
Date: Sun, 21 Mar 2010 21:19:49 +0100 [thread overview]
Message-ID: <1269202789-8833-2-git-send-email-srabbelier@gmail.com> (raw)
In-Reply-To: <1269202789-8833-1-git-send-email-srabbelier@gmail.com>
Currently when using a remote helper to clone a repository, the
remote helper will be passed the url of the target repository as
first argument (which represents the name of the remote). This name
is extracted from transport->remote->name, which is set by
builtin/clone.c when it calls remote_get with argv[0] as argument.
Fix this by passing the name remote will be set up as instead.
---
I've spent quite a few hours trying to figure out why this broke
t5700, so I would appreciate feedback from those with more
knowledge about hardlinking and clone/fetch in general as to
whether this couild cause any problems.
builtin/clone.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin/clone.c b/builtin/clone.c
index f878563..068d61f 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -513,7 +513,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
refs = clone_local(path, git_dir);
mapped_refs = wanted_peer_refs(refs, refspec);
} else {
- struct remote *remote = remote_get(argv[0]);
+ struct remote *remote = remote_get(option_origin);
transport = transport_get(remote, remote->url[0]);
if (!transport->get_refs_list || !transport->fetch)
--
1.7.0.2.325.g634e5
next prev parent reply other threads:[~2010-03-21 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-21 20:19 [PATCH 1/2] Move setup_reference to after writing the config file Sverre Rabbelier
2010-03-21 20:19 ` Sverre Rabbelier [this message]
2010-03-21 23:27 ` [PATCH 2/2] clone: pass the remote name to remote_get Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269202789-8833-2-git-send-email-srabbelier@gmail.com \
--to=srabbelier@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=tali@admingilde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).