git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael J Gruber" <git@drmicha.warpmail.net>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] clone: quell the progress report from init and report on clone
Date: Sun, 04 Apr 2010 15:02:15 +0200	[thread overview]
Message-ID: <1270386135.1675.1368217929@webmail.messagingengine.com> (raw)
In-Reply-To: <7vljd6l3dn.fsf@alter.siamese.dyndns.org>

On Fri, 02 Apr 2010 00:28 -0700, "Junio C Hamano" <gitster@pobox.com>
wrote:
> Michael J Gruber <git@drmicha.warpmail.net> writes:
> 
> > From: Junio C Hamano <gitster@pobox.com>
> >
> > Currently, a local glit clone reports only initializing an empty
> > git dir, which is potentially confusing.
> 
> glit?

Sorry, this glitch clomes from the clone clommand of glit.
 
> > Instead, report that cloning is in progress and when it is done
> > (unless -q) is given, and suppres the init report (unless -v
> > is given).
> >
> > Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
> > ---
> > I checked the documentation, there is really no place where the output
> > of git clone is documented - no documentation or test change is necesessary.
> 
> Thanks.
> 
> > I made it so that -v will restore the init message.
> 
> I wonder how that would be useful, though.  The new message already says
> which directory is being worked on.  I didn't see a point of repeating
> that and made it silent on purpose.
 
Well, the idea is that '-v' should do at least something, and often (for
other commands) shows the individual steps of an action. The steps here
are init+clone.
Personally, I don't really care for either option.

Michael
P.S.: I'm sparsely online this week. Please don't mind if my responses
come in late.

  reply	other threads:[~2010-04-04 13:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-24 22:44 color (red) for error messages on all git commands Neal Kreitzinger
2010-03-24 22:58 ` Sverre Rabbelier
2010-03-24 23:12   ` Alex Riesen
2010-03-25  8:43     ` Michael J Gruber
2010-03-25  8:46       ` [PATCH RFC/RFD] clone: quell the progress report from init Michael J Gruber
2010-03-25  9:02         ` Alex Riesen
2010-03-25  9:26           ` Michael J Gruber
2010-03-25 16:31         ` Tilo Schwarz
2010-03-26 19:32         ` Junio C Hamano
2010-03-26 20:16           ` Nicolas Pitre
2010-03-26 20:24             ` Junio C Hamano
2010-03-30  5:18             ` Junio C Hamano
2010-03-30  8:05               ` Michael J Gruber
2010-03-30  8:43               ` Alex Riesen
2010-04-01 22:03               ` [PATCH] clone: quell the progress report from init and report on clone Michael J Gruber
2010-04-02  7:28                 ` Junio C Hamano
2010-04-04 13:02                   ` Michael J Gruber [this message]
2010-04-23 12:37                     ` Michael J Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1270386135.1675.1368217929@webmail.messagingengine.com \
    --to=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).