From: David Aguilar <davvid@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Brian Gernhardt <brian@gernhardtsoftware.com>,
Git List <git@vger.kernel.org>, Johan Herland <johan@herland.net>,
Sverre Rabbelier <srabbelier@gmail.com>
Subject: [PATCH] Makefile: Avoid multi-line sed when building python scripts
Date: Fri, 9 Apr 2010 01:42:39 -0700 [thread overview]
Message-ID: <1270802559-14791-1-git-send-email-davvid@gmail.com> (raw)
In-Reply-To: <20100409080256.GA12527@gmail.com>
Instead of requiring scripts to start with "import sys",
install the sys.path initialization code immediately
after each script's new shebang line.
This works around portability issues with multi-line sed and
simplifies the work for contributors. There is no longer
the requirement that every script must "import sys" before
importing git-provided modules.
Signed-off-by: David Aguilar <davvid@gmail.com>
---
Makefile | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/Makefile b/Makefile
index 956e781..b763947 100644
--- a/Makefile
+++ b/Makefile
@@ -1608,12 +1608,10 @@ $(patsubst %.py,%,$(SCRIPT_PYTHON)): % : %.py
--no-print-directory prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' \
instlibdir` && \
sed -e '1{' \
- -e ' s|#!.*python|#!$(PYTHON_PATH_SQ)|' \
+ -e ' s|#!.*python|#!$(PYTHON_PATH_SQ)\n@@STARTUP@@|' \
-e '}' \
- -e 's|^import sys.*|&; \\\
- import os; \\\
- sys.path.insert(0, os.getenv("GITPYTHONLIB",\
- "@@INSTLIBDIR@@"));|' \
+ -e 's|@@STARTUP@@|import os, sys; sys.path.insert(0, @@ENV@@)|' \
+ -e 's|@@ENV@@|os.getenv("GITPYTHONLIB", "@@INSTLIBDIR@@")|' \
-e 's|@@INSTLIBDIR@@|'"$$INSTLIBDIR"'|g' \
$@.py >$@+ && \
chmod +x $@+ && \
--
1.7.0.3.313.g87b3c
next prev parent reply other threads:[~2010-04-09 8:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 3:22 [PATCH] Makefile: Remove excess backslashes from sed Brian Gernhardt
2010-04-09 5:57 ` Junio C Hamano
2010-04-09 8:02 ` David Aguilar
2010-04-09 8:42 ` David Aguilar [this message]
2010-04-09 14:33 ` Brian Gernhardt
2010-04-09 15:34 ` Sverre Rabbelier
2010-04-09 15:35 ` [PATCH] Makefile: Simplify handling of python scripts Brian Gernhardt
2010-04-09 6:04 ` [PATCH] Makefile: Remove excess backslashes from sed David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270802559-14791-1-git-send-email-davvid@gmail.com \
--to=davvid@gmail.com \
--cc=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).