From: Tay Ray Chuan <rctay89@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Johannes Sixt <j.sixt@viscovery.net>
Subject: [PATCH v2] branch: say "Reset to" in reflog entries for 'git branch -f' operations
Date: Fri, 9 Apr 2010 20:38:18 +0800 [thread overview]
Message-ID: <1270816698-3464-1-git-send-email-rctay89@gmail.com> (raw)
In-Reply-To: <1270799112-4308-1-git-send-email-rctay89@gmail.com>
In 5f856dd (fix reflog entries for "git-branch"), it is mentioned that
'git branch -f' is intended to be equivalent to 'git reset'. Since we
usually say "reset to <commit>" in the git-reset Documentation and
elsewhere, it would make sense to say "Reset to" here as well, instead
of "Reset from" previously.
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
---
Changed from v1:
- Mention old reflog message in patch message, as suggested by
Michael J Gruber.
branch.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/branch.c b/branch.c
index 9e1f63e..2ab42aa 100644
--- a/branch.c
+++ b/branch.c
@@ -198,7 +198,7 @@ void create_branch(const char *head,
log_all_ref_updates = 1;
if (forcing)
- snprintf(msg, sizeof msg, "branch: Reset from %s",
+ snprintf(msg, sizeof msg, "branch: Reset to %s",
start_name);
else if (!dont_change_ref)
snprintf(msg, sizeof msg, "branch: Created from %s",
--
1.7.1.rc0.240.gba75f
prev parent reply other threads:[~2010-04-09 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 7:45 [PATCH] branch: say "Reset to" in reflog entries for 'git branch -f' operations Tay Ray Chuan
2010-04-09 11:55 ` Michael J Gruber
2010-04-09 12:03 ` Matthieu Moy
2010-04-09 12:20 ` Johannes Sixt
2010-04-09 12:18 ` Tay Ray Chuan
2010-04-09 12:38 ` Tay Ray Chuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270816698-3464-1-git-send-email-rctay89@gmail.com \
--to=rctay89@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).