From: Brian Gernhardt <brian@gernhardtsoftware.com>
To: Git List <git@vger.kernel.org>
Cc: Jakub Narebski <jnareb@gmail.com>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v3 1/4] send-email: Cleanup { style
Date: Sat, 10 Apr 2010 10:53:53 -0400 [thread overview]
Message-ID: <1270911236-32476-2-git-send-email-brian@gernhardtsoftware.com> (raw)
In-Reply-To: <1270911236-32476-1-git-send-email-brian@gernhardtsoftware.com>
As Jakub Narebski pointed out on the list, Perl code usually prefers
sub func {
}
over
sub func
{
}
git-send-email.perl is somewhat inconsistent in its style, with 23
subroutines using the first style and 6 using the second. Convert the
few odd subroutines so that the code matches normal Perl style.
Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com>
---
git-send-email.perl | 18 ++++++------------
1 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index ce569a9..26fe624 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -761,8 +761,7 @@ sub extract_valid_address {
# We'll setup a template for the message id, using the "from" address:
my ($message_id_stamp, $message_id_serial);
-sub make_message_id
-{
+sub make_message_id {
my $uniq;
if (!defined $message_id_stamp) {
$message_id_stamp = sprintf("%s-%s", time, $$);
@@ -817,8 +816,7 @@ sub is_rfc2047_quoted {
}
# use the simplest quoting being able to handle the recipient
-sub sanitize_address
-{
+sub sanitize_address {
my ($recipient) = @_;
my ($recipient_name, $recipient_addr) = ($recipient =~ /^(.*?)\s*(<.*)/);
@@ -863,8 +861,7 @@ sub sanitize_address
# This maildomain*() code is based on ideas in Perl library Test::Reporter
# /usr/share/perl5/Test/Reporter/Mail/Util.pm ==> sub _maildomain ()
-sub maildomain_net
-{
+sub maildomain_net {
my $maildomain;
if (eval { require Net::Domain; 1 }) {
@@ -876,8 +873,7 @@ sub maildomain_net
return $maildomain;
}
-sub maildomain_mta
-{
+sub maildomain_mta {
my $maildomain;
if (eval { require Net::SMTP; 1 }) {
@@ -898,8 +894,7 @@ sub maildomain_mta
return $maildomain;
}
-sub maildomain
-{
+sub maildomain {
return maildomain_net() || maildomain_mta() || $mail_domain_default;
}
@@ -907,8 +902,7 @@ sub maildomain
# In actuality, the whole program dies when there
# is an error sending a message.
-sub send_message
-{
+sub send_message {
my @recipients = unique_email_list(@to);
@cc = (grep { my $cc = extract_valid_address($_);
not grep { $cc eq $_ } @recipients
--
1.7.1.rc0.251.g42f41
next prev parent reply other threads:[~2010-04-10 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-10 14:53 [PATCH v3 0/4] send-email: --smtp-domain improvements Brian Gernhardt
2010-04-10 14:53 ` Brian Gernhardt [this message]
2010-04-10 20:02 ` [PATCH v3 1/4] send-email: Cleanup { style Junio C Hamano
2010-04-10 14:53 ` [PATCH v3 2/4] send-email: Don't use FQDNs without a '.' Brian Gernhardt
2010-04-10 14:53 ` [PATCH v3 3/4] Document send-email --smtp-domain Brian Gernhardt
2010-04-10 14:53 ` [PATCH v3 4/4] send-email: Cleanup smtp-domain and add config Brian Gernhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270911236-32476-2-git-send-email-brian@gernhardtsoftware.com \
--to=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).