From: Will Palmer <wmpalmer@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, gitster@pobox.com,
Cheng Renquan <crquan@gmail.com>
Subject: Re: [PATCH 0/3] pretty: format aliases
Date: Mon, 26 Apr 2010 22:14:21 +0100 [thread overview]
Message-ID: <1272316461.5368.4.camel@walleee> (raw)
In-Reply-To: <20100426183755.GC11378@progeny.tock>
On Mon, 2010-04-26 at 13:37 -0500, Jonathan Nieder wrote:
> Alternatively, we could use
>
> [logformat]
> changelog = ...
>
> which is arguably just as clear and may be closer to existing
> practice. But really, I am happy as long as the configuration exists.
>
> Jonathan
I like the one-level-of-hierarchy thing ([format "pretty"] is ugly for a
number of reasons), but two problems with that specific name:
- it says "log", while this effects more than the "log" command
- it says "format", while this doesn't effect --format.
[pretty]
changelog = ...
is not taken, and my only hesitation there is that some other config
option may want to be there. Still, it's what I'll call it in the next
version of the patch, unless there are specific objections. (which I
certainly may have already missed, as I've just switched mail clients
twice today)
-- Will
next prev parent reply other threads:[~2010-04-26 21:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-25 15:42 [PATCH 0/3] pretty: format aliases Will Palmer
2010-04-25 15:42 ` [PATCH 1/3] pretty: add conditional %C?colorname placeholders Will Palmer
2010-04-26 6:30 ` Alex Riesen
[not found] ` <r2o5b9751661004260113m7b6c387bm8467a063c13e5a0f@mail.gmail.com>
2010-04-26 8:20 ` Will Palmer
2010-04-25 15:42 ` [PATCH 2/3] pretty: make %H/%h dependent on --abbrev[-commit] Will Palmer
2010-04-25 15:42 ` [PATCH 3/3] pretty: add aliases for pretty formats Will Palmer
2010-04-25 19:48 ` [PATCH 0/3] pretty: format aliases Jeff King
2010-04-25 20:40 ` Will Palmer
2010-04-25 22:09 ` Jonathan Nieder
2010-04-26 17:22 ` Jeff King
2010-04-26 17:57 ` Jonathan Nieder
2010-04-26 18:07 ` Jeff King
2010-04-26 18:37 ` Jonathan Nieder
2010-04-26 21:14 ` Will Palmer [this message]
2010-04-26 22:00 ` Jonathan Nieder
2010-04-27 1:25 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272316461.5368.4.camel@walleee \
--to=wmpalmer@gmail.com \
--cc=crquan@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).