git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Will Palmer <wmpalmer@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
	git@vger.kernel.org, raa.lkml@gmail.com, jrnieder@gmail.com
Subject: Re: [PATCH v3 2/5] pretty: make %H/%h/etc respect --abbrev[-commit]
Date: Sun, 02 May 2010 08:52:51 +0100	[thread overview]
Message-ID: <1272786771.4194.13.camel@walleee> (raw)
In-Reply-To: <7v39yazx4i.fsf@alter.siamese.dyndns.org>

On Sat, 2010-05-01 at 22:33 -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
> 
> > On Sat, May 01, 2010 at 08:13:00PM -0700, Junio C Hamano wrote:
> >

Sounds like this one remains controversial. I'll pull the format changes
out of the next pretty-alias series, and submit them as separate patches
later on. I still think the documentation implies that %H should be
abbreviated when --abbrev-commit is passed, but for now I'm going to
focus on cleaning up the pretty.alias code.
The eventual solution, I suspect, will involve a more-generic syntax as
was brought up in the previous discussion. Something like
%(abbrev-commit?%H), which would also be able to play with something
like [but, for obvious reasons, not exactly] %(is-merge?Merge: %p %p)

The %?C syntax seems to be generating less comment this time, and is the
one that I would find the most important to extending the usefulness of
format-aliases (ie: so that I can view a custom log with color in a
terminal, then output it to a text file and have it "do the right
thing"). Still, it would be lonely without %H/%h, so I'll stick it in
its own patch as well (once I fix it up a bit more, as mentioned in the
other thread).

-- 
-- Will

  parent reply	other threads:[~2010-05-02  7:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-30 19:35 [PATCH v3 0/5] pretty: format aliases Will Palmer
2010-04-30 19:35 ` [PATCH v3 1/5] pretty: add conditional %C?colorname placeholders Will Palmer
2010-05-02  3:12   ` Junio C Hamano
2010-05-02  9:31     ` Will Palmer
2010-04-30 19:35 ` [PATCH v3 2/5] pretty: make %H/%h/etc respect --abbrev[-commit] Will Palmer
2010-05-02  3:13   ` Junio C Hamano
2010-05-02  4:45     ` Jeff King
2010-05-02  5:33       ` Junio C Hamano
2010-05-02  5:40         ` Jeff King
2010-05-02  7:52         ` Will Palmer [this message]
2010-05-02  8:50     ` Will Palmer
2010-05-02  9:11       ` Junio C Hamano
2010-05-02  9:17         ` Jonathan Nieder
2010-04-30 19:35 ` [PATCH v3 3/5] pretty: make it easier to add new formats Will Palmer
2010-04-30 19:35 ` [PATCH v3 4/5] pretty: add infrastructure to allow format aliases Will Palmer
2010-05-02  3:13   ` Junio C Hamano
2010-05-02  9:01     ` Will Palmer
2010-04-30 19:35 ` [PATCH v3 5/5] pretty: add aliases for pretty formats Will Palmer
2010-05-02  3:13   ` Junio C Hamano
2010-05-02  4:47   ` Jeff King
2010-05-02  3:12 ` [PATCH v3 0/5] pretty: format aliases Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1272786771.4194.13.camel@walleee \
    --to=wmpalmer@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=peff@peff.net \
    --cc=raa.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).