From: Will Palmer <wmpalmer@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, peff@peff.net, raa.lkml@gmail.com,
jrnieder@gmail.com
Subject: Re: [PATCH v3 2/5] pretty: make %H/%h/etc respect --abbrev[-commit]
Date: Sun, 02 May 2010 09:50:55 +0100 [thread overview]
Message-ID: <1272790255.4258.11.camel@walleee> (raw)
In-Reply-To: <7vocgzyp1f.fsf@alter.siamese.dyndns.org>
On Sat, 2010-05-01 at 20:13 -0700, Junio C Hamano wrote:
> I think it is a good change to make %h follow --abbrev, but %H should stay
> the full length no matter what (otherwise why would anybody use %H not %h?).
I could just as easily say "why would anyone pass --abbrev-commit unless
they actually wanted an abbreviated commit?". Synonyms are confusing,
but ignored parameters sound more confusing to me.
While I disagree that --abbrev-commit should have no effect whatsoever
when %H is involved, I agree that the link between %h and --abbrev is
more solid, so I will split %h respecting --abbrev into a separate
patch.
If the current behaviour is actually intentional, we should at least
update the documentation to say that %H is the "full commit hash",
rather than just the "commit hash".
--
-- Will
next prev parent reply other threads:[~2010-05-02 8:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 19:35 [PATCH v3 0/5] pretty: format aliases Will Palmer
2010-04-30 19:35 ` [PATCH v3 1/5] pretty: add conditional %C?colorname placeholders Will Palmer
2010-05-02 3:12 ` Junio C Hamano
2010-05-02 9:31 ` Will Palmer
2010-04-30 19:35 ` [PATCH v3 2/5] pretty: make %H/%h/etc respect --abbrev[-commit] Will Palmer
2010-05-02 3:13 ` Junio C Hamano
2010-05-02 4:45 ` Jeff King
2010-05-02 5:33 ` Junio C Hamano
2010-05-02 5:40 ` Jeff King
2010-05-02 7:52 ` Will Palmer
2010-05-02 8:50 ` Will Palmer [this message]
2010-05-02 9:11 ` Junio C Hamano
2010-05-02 9:17 ` Jonathan Nieder
2010-04-30 19:35 ` [PATCH v3 3/5] pretty: make it easier to add new formats Will Palmer
2010-04-30 19:35 ` [PATCH v3 4/5] pretty: add infrastructure to allow format aliases Will Palmer
2010-05-02 3:13 ` Junio C Hamano
2010-05-02 9:01 ` Will Palmer
2010-04-30 19:35 ` [PATCH v3 5/5] pretty: add aliases for pretty formats Will Palmer
2010-05-02 3:13 ` Junio C Hamano
2010-05-02 4:47 ` Jeff King
2010-05-02 3:12 ` [PATCH v3 0/5] pretty: format aliases Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272790255.4258.11.camel@walleee \
--to=wmpalmer@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).