From: Will Palmer <wmpalmer@gmail.com>
To: git@vger.kernel.org
Cc: wmpalmer@gmail.com, gitster@pobox.com, peff@peff.net, jrnieder@gmail.com
Subject: [PATCH v4 0/3] pretty: format aliases
Date: Sun, 2 May 2010 12:00:41 +0100 [thread overview]
Message-ID: <1272798044-10487-1-git-send-email-wmpalmer@gmail.com> (raw)
The following patch series adds the ability to configure aliases for
user-defined formats. The first two patches add infrastructure for the
ease of adding additional formats, and infrastructure for defining
format aliases, respectively. The final patch adds support for defining
format aliases via a config option.
This is the fourth version of the patch series. The most notable change
from the last iteration is the removal of changes to other pretty-format
options, such as the "conditional colors" patch and "%H/%h --abbrev"
patches. I still think those were good patches, but the %H change in
particular was controversial enough that it would have needlessly stood
in the way of the rest of the series, and '%?C' looked out-of-place in
this series without any other format changes. The removed patches will
be worked on independently and will be submitted separately later.
Jeff King noted an artifact of format.pretty.<name> left in the
documentation, thanks.
Junio asked for a better error message when looped-aliases were found,
so that's been put in.
The copyright notice for the added test has been changed to the standard
boilerplate, because there's no reason to bring politics into a patch.
Most other changes since the last iteration were simple style fixes,
mostly a result of muscle memory from the coding conventions I use at
work, though a couple of things (like not initializing static variables)
were more towards the "you can do that? But my CS teacher in highschool
told me not to!" end of the spectrum. Hopefully I've caught all the
style problems this time.
Will Palmer (3):
pretty: make it easier to add new formats
pretty: add infrastructure to allow format aliases
pretty: add aliases for pretty formats
Documentation/config.txt | 9 ++
Documentation/pretty-formats.txt | 7 ++-
pretty.c | 154 ++++++++++++++++++++++++++++++++------
t/t4205-log-pretty-formats.sh | 66 ++++++++++++++++
4 files changed, 212 insertions(+), 24 deletions(-)
create mode 100755 t/t4205-log-pretty-formats.sh
next reply other threads:[~2010-05-02 11:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-02 11:00 Will Palmer [this message]
2010-05-02 11:00 ` [PATCH v4 1/3] pretty: make it easier to add new formats Will Palmer
2010-05-02 11:22 ` Jonathan Nieder
2010-05-02 11:00 ` [PATCH v4 2/3] pretty: add infrastructure to allow format aliases Will Palmer
2010-05-02 11:55 ` Jonathan Nieder
2010-05-02 11:00 ` [PATCH v4 3/3] pretty: add aliases for pretty formats Will Palmer
2010-05-02 12:30 ` Jonathan Nieder
2010-05-02 13:38 ` Will Palmer
2010-05-08 21:07 ` [PATCH] pretty: initialize new cmt_fmt_map to 0 Jonathan Nieder
2010-05-08 22:04 ` Will Palmer
2010-05-02 15:53 ` [PATCH v4 0/3] pretty: format aliases Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272798044-10487-1-git-send-email-wmpalmer@gmail.com \
--to=wmpalmer@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).