From: Will Palmer <wmpalmer@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com, peff@peff.net
Subject: Re: [PATCH v4 3/3] pretty: add aliases for pretty formats
Date: Sun, 02 May 2010 14:38:20 +0100 [thread overview]
Message-ID: <1272807500.24767.4.camel@dreddbeard> (raw)
In-Reply-To: <20100502123039.GB13419@progeny.tock>
On Sun, 2010-05-02 at 07:30 -0500, Jonathan Nieder wrote:
> Likewise.
>
> With whatever subset of the above changes you deem suitable,
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Thanks again.
>
I'm not familiar enough with the patch submission process. Should I add
your changes (all except for the config documentation I agree with, and
that one I agree with the reasoning for) into my series and re-submit,
or is saying "I agree with those changes" enough to assume that they
will be applied to my series if it is accepted?
--
-- Will
next prev parent reply other threads:[~2010-05-02 13:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-02 11:00 [PATCH v4 0/3] pretty: format aliases Will Palmer
2010-05-02 11:00 ` [PATCH v4 1/3] pretty: make it easier to add new formats Will Palmer
2010-05-02 11:22 ` Jonathan Nieder
2010-05-02 11:00 ` [PATCH v4 2/3] pretty: add infrastructure to allow format aliases Will Palmer
2010-05-02 11:55 ` Jonathan Nieder
2010-05-02 11:00 ` [PATCH v4 3/3] pretty: add aliases for pretty formats Will Palmer
2010-05-02 12:30 ` Jonathan Nieder
2010-05-02 13:38 ` Will Palmer [this message]
2010-05-08 21:07 ` [PATCH] pretty: initialize new cmt_fmt_map to 0 Jonathan Nieder
2010-05-08 22:04 ` Will Palmer
2010-05-02 15:53 ` [PATCH v4 0/3] pretty: format aliases Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272807500.24767.4.camel@dreddbeard \
--to=wmpalmer@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).