* [PATCH] gitk: Decode the "-n" argument properly for Edit View
@ 2010-05-04 15:05 Jim Ramsay
0 siblings, 0 replies; 2+ messages in thread
From: Jim Ramsay @ 2010-05-04 15:05 UTC (permalink / raw)
To: git
Running 'gitk -n 42' and selecting View > Edit View... would previously put the
'-n' half of the argument-pair in the box labeled "Additional arguments to git
log" and the '42' in "Branches & Tags". Parse this pair properly and use the
numerical portion for the 'limit' value.
Signed-off-by: Jim Ramsay <i.am@jimramsay.com>
---
gitk-git/gitk | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 1b0e09a..f93e7e5 100644
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -3907,6 +3907,17 @@ proc decode_view_opts {n view_args} {
set oargs [list]
set refargs [list]
foreach arg $view_args {
+ # Decode 2-argument '-n 42' as 'limit'
+ if {[info exists haslimitarg]} {
+ set newviewopts($n,limit) $arg
+ set found(limit) 1
+ unset haslimitarg
+ continue
+ }
+ if {$arg eq "-n"} {
+ set haslimitarg 1
+ continue
+ }
if {[regexp -- {^-([0-9]+)$} $arg arg cnt]
&& ![info exists found(limit)]} {
set newviewopts($n,limit) $cnt
--
1.7.0.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] gitk: Decode the "-n" argument properly for Edit View
@ 2010-06-10 16:33 Jim Ramsay
0 siblings, 0 replies; 2+ messages in thread
From: Jim Ramsay @ 2010-06-10 16:33 UTC (permalink / raw)
To: paulus; +Cc: git
Running 'gitk -n 42' and selecting View > Edit View... would previously
put the '-n' half of the argument-pair in the box labeled "Additional
arguments to git log" and the '42' in "Branches & Tags". Parse this
pair properly and use the numerical portion for the 'limit' value.
Signed-off-by: Jim Ramsay <i.am@jimramsay.com>
---
gitk-git/gitk | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 1b0e09a..f93e7e5 100644
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -3907,6 +3907,17 @@ proc decode_view_opts {n view_args} {
set oargs [list]
set refargs [list]
foreach arg $view_args {
+ # Decode 2-argument '-n 42' as 'limit'
+ if {[info exists haslimitarg]} {
+ set newviewopts($n,limit) $arg
+ set found(limit) 1
+ unset haslimitarg
+ continue
+ }
+ if {$arg eq "-n"} {
+ set haslimitarg 1
+ continue
+ }
if {[regexp -- {^-([0-9]+)$} $arg arg cnt]
&& ![info exists found(limit)]} {
set newviewopts($n,limit) $cnt
--
1.7.0.2
--
Jim Ramsay
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-10 16:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-04 15:05 [PATCH] gitk: Decode the "-n" argument properly for Edit View Jim Ramsay
-- strict thread matches above, loose matches on Subject: below --
2010-06-10 16:33 Jim Ramsay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).