From: Marcus Comstedt <marcus@mc.pp.se>
To: git@vger.kernel.org
Cc: Marcus Comstedt <marcus@mc.pp.se>
Subject: [PATCH 1/2] Added "Z" as an alias for the timezone "UTC"
Date: Mon, 17 May 2010 21:07:10 +0200 [thread overview]
Message-ID: <1274123231-18482-2-git-send-email-marcus@mc.pp.se> (raw)
In-Reply-To: <1274123231-18482-1-git-send-email-marcus@mc.pp.se>
The name "Z" for the UTC timezone is required to properly parse
ISO 8601 times. Added it to the list of recignozed timezones.
Also, fixed the bug that timezone names shorter than 3 characters
can never be matched by match_alpha(). Prior to the introduction
of the "Z" zone, this affected the timezone "NT" (Nome).
Signed-off-by: Marcus Comstedt <marcus@mc.pp.se>
---
:100644 100644 002aa3c... 6bae49c... M date.c
date.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/date.c b/date.c
index 002aa3c..6bae49c 100644
--- a/date.c
+++ b/date.c
@@ -229,6 +229,7 @@ static const struct {
{ "GMT", 0, 0, }, /* Greenwich Mean */
{ "UTC", 0, 0, }, /* Universal (Coordinated) */
+ { "Z", 0, 0, }, /* Zulu, alias for UTC */
{ "WET", 0, 0, }, /* Western European */
{ "BST", 0, 1, }, /* British Summer */
@@ -305,7 +306,7 @@ static int match_alpha(const char *date, struct tm *tm, int *offset)
for (i = 0; i < ARRAY_SIZE(timezone_names); i++) {
int match = match_string(date, timezone_names[i].name);
- if (match >= 3) {
+ if (match >= 3 || match == strlen(timezone_names[i].name)) {
int off = timezone_names[i].offset;
/* This is bogus, but we like summer */
--
1.7.0.4
next prev parent reply other threads:[~2010-05-17 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 19:07 PATCH: Improved support for ISO 8601 timezones Marcus Comstedt
2010-05-17 19:07 ` Marcus Comstedt [this message]
2010-05-17 20:32 ` [PATCH 1/2] Added "Z" as an alias for the timezone "UTC" Jay Soffian
2010-05-17 19:07 ` [PATCH 2/2] Accept the timezone specifiers [+-]hh:mm and [+-]hh in addition to [+-]hhmm Marcus Comstedt
2010-05-19 14:31 ` Junio C Hamano
2010-05-19 17:21 ` Marcus Comstedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274123231-18482-2-git-send-email-marcus@mc.pp.se \
--to=marcus@mc.pp.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).