From: Marcus Comstedt <marcus@mc.pp.se>
To: git@vger.kernel.org
Cc: Marcus Comstedt <marcus@mc.pp.se>
Subject: [PATCH 2/2] Accept the timezone specifiers [+-]hh:mm and [+-]hh in addition to [+-]hhmm
Date: Mon, 17 May 2010 21:07:11 +0200 [thread overview]
Message-ID: <1274123231-18482-3-git-send-email-marcus@mc.pp.se> (raw)
In-Reply-To: <1274123231-18482-1-git-send-email-marcus@mc.pp.se>
ISO 8601 specifies three syntaxes for timezones other than "Z".
git already supports the +-hhmm syntax. This patch adds support
for the other two: +-hh:mm and +-hh.
Signed-off-by: Marcus Comstedt <marcus@mc.pp.se>
---
:100644 100644 6bae49c... f83e46e... M date.c
date.c | 23 +++++++++++++++++++++++
1 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/date.c b/date.c
index 6bae49c..f83e46e 100644
--- a/date.c
+++ b/date.c
@@ -555,6 +555,18 @@ static int match_tz(const char *date, int *offp)
int min, hour;
int n = end - date - 1;
+ /* Check for HH:MM format, allowed by ISO 8601 */
+ if (n == 2 && date[3] == ':') {
+ char *end2;
+ min = strtoul(date+4, &end2, 10);
+ /* If we have two digits after the colon too, assume HH:MM */
+ if (end2 == date+6) {
+ offset = offset*100 + min;
+ end = end2;
+ n = end - date - 1;
+ }
+ }
+
min = offset % 100;
hour = offset / 100;
@@ -570,6 +582,17 @@ static int match_tz(const char *date, int *offp)
*offp = offset;
}
+ /*
+ * Also accept just the hour, allowed by ISO 8601
+ */
+ else if (n == 2 && hour == 0 && min < 24) {
+ offset = min*60;
+ if (*date == '-')
+ offset = -offset;
+
+ *offp = offset;
+ }
+
return end - date;
}
--
1.7.0.4
next prev parent reply other threads:[~2010-05-17 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 19:07 PATCH: Improved support for ISO 8601 timezones Marcus Comstedt
2010-05-17 19:07 ` [PATCH 1/2] Added "Z" as an alias for the timezone "UTC" Marcus Comstedt
2010-05-17 20:32 ` Jay Soffian
2010-05-17 19:07 ` Marcus Comstedt [this message]
2010-05-19 14:31 ` [PATCH 2/2] Accept the timezone specifiers [+-]hh:mm and [+-]hh in addition to [+-]hhmm Junio C Hamano
2010-05-19 17:21 ` Marcus Comstedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274123231-18482-3-git-send-email-marcus@mc.pp.se \
--to=marcus@mc.pp.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).