From: Marcus Comstedt <marcus@mc.pp.se>
To: git@vger.kernel.org
Subject: [PATCHv2] Accept the timezone specifiers [+-]hh:mm and [+-]hh in addition to [+-]hhmm
Date: Wed, 19 May 2010 22:49:36 +0200 [thread overview]
Message-ID: <1274302177-3573-1-git-send-email-marcus@mc.pp.se> (raw)
Ok, here's a new attempt for the +hh(:mm) timezones, which should be
semantically equivalent to the previous one. In particular, I tested
the following corner cases:
check_parse '+31/05/06 1980 01:02:03' '1980-05-06 01:02:03 +0000'
check_parse '+1979/05/06/03 01:02:03' '2003-05-06 01:02:03 +0000'
check_parse '+11:5:6 1999/04/01' '1999-03-31 18:06:00 +0000'
check_parse '+11:73 Jun 15 10:00:00' bad
I'm not arguing that these results are "correct" or anything, I just
observe that it was like that before, and so by conservatively not
changing them, I shouldn't break anything...
(Ok, the last one _is_ a change from how it was in the before time,
in the long long ago, but it's the same as it was with the last
version of the patch.)
// Marcus
next reply other threads:[~2010-05-19 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 20:49 Marcus Comstedt [this message]
2010-05-19 20:49 ` [PATCH] Accept the timezone specifiers [+-]hh:mm and [+-]hh in addition to [+-]hhmm Marcus Comstedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274302177-3573-1-git-send-email-marcus@mc.pp.se \
--to=marcus@mc.pp.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).