git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* can pre-commit hook accept user input?
@ 2010-05-22  1:41 Neal Kreitzinger
  2010-05-22  1:45 ` Shawn O. Pearce
  2010-05-22 12:11 ` Marc Weber
  0 siblings, 2 replies; 3+ messages in thread
From: Neal Kreitzinger @ 2010-05-22  1:41 UTC (permalink / raw)
  To: git

Hi,

Can the pre-commit hook accept user input?  I'm new to linux and bash 
scripting and here's what I'm trying.  (It appears to work in a manually 
executed script.)  The 'read' commands do not let me input anything when 
running in a hook. (I've inserted a non-loop test at the beginning to be 
sure.)  The script just keeps going with a value of 'nothing' in the input 
variable.  This, of course, causes and endless loop in the code that I 
really want to use.

#!/bin/bash
#*******************************************************************************
#* PGM NAME: pre-commit  A hook script to verify what is about to be 
committed**
#*                       Called by git-commit with no arguments.  The hook 
**
#*                       should exit with non-zero status after issuing an 
**
#*                       appropriate message if it wants to stop the commit. 
**
#*                          MODIFICATION LOG 
**
#* PROJ#   DATE PRGMR        DESCRIPTION 
**
#* 000057 04/10 NEAL K    INSPECT SOURCE FILES FOR HEADER USER/DATE STAMP. 
**
#*                        PROMPT FOR VERIFICATION OF DD CHANGES. WARNING: 
**
#*                        TRACKED WORKING COPY FILES WILL BE STAGED IF THEIR 
**
#*                        INDEX ENTRY DIFFERS FROM THE HEAD COMMIT! 
**
#* 000378 05/10 NEAL K    BUGFIX: ONLY INSPECT/STAGE OBJECTS WHOSE INDEX 
ENTRY**
#*                        DIFFERS FROM THE HEAD COMMIT. MOD: MORE INFO IN 
**
#*                        HEADER STAMP WARNING. WARN/PROMPT TO STAGE WORKING 
**
#*                        COPIES OF STAGED FILES. 
**
#*******************************************************************************
echo "Start pre-commit hook... Confirmation:"
echo enter your name
read NAME
echo "hi $NAME"
# 
x
CONFIRMED="N"
until [ $CONFIRMED = "Y" ]; do
  echo "Any unstaged changes to staged files will be staged. 
Continue?(Y/N/H)elp"
  read CONFIRM
  case "$CONFIRM" in
    "Y" )
      echo "Re-staging algorithm approved by User. Continue pre-commit 
hook..."
      CONFIRMED="Y";;
    "N" )
      echo "Commit Aborted by User."
      exit 3;;
    "H" )
      echo "Example:"
      echo "1. After the last commit, you changed RCUSTMNT and staged it. 
We'll call this  "
      echo "   staged version of RCUSTMNT 'RCUSTMNT NEW'."
      echo "2. Then you modified RCUSTMNT again, but did not stage it again. 
We'll call    "
      echo "   this working copy version of RCUSTMNT 'RCUSTMNT NEWEST'. "
      echo "THIS SCRIPT WILL STAGE AND COMMIT 'RCUSTMNT NEWEST'!"
      echo "*This behavior is based on the notion that you will not have 
unstaged changes  "
      echo " to your staged source files.";;
    * )
      echo "Please enter Y, N, or H (Help)";;
  esac
done
ABORTMSG="Commit Aborted!"
DIFFFILES=`git diff-index HEAD --cached --name-only SRC/*/*`
if [ $? -ne 0 ]; then
  echo "Error running git diff-index command"
  echo $ABORTMSG
  exit 4
fi
for FILES in ${DIFFFILES}
  do
# 
x
# 
12345678901234567890
  echo "inspecting working copy & staged copy of staged source file:$FILES"
  if [ ! -r ${FILES} ]; then
    echo "${FILES} needs read permission"
    echo $ABORTMSG
    exit 6
  fi
  if [ ! -w ${FILES} ]; then
    echo "${FILES} needs write permission"
    echo $ABORTMSG
    exit 6
  fi
  CHKUSER=$(/usr/bin/head -1 ${FILES} | /bin/egrep -c '\$User\$|\$User:')
  CHKDATE=$(/usr/bin/head -1 ${FILES} | /bin/egrep -c '\$Date\$|\$Date:')
  if [ ${CHKUSER} -ne 1 -o ${CHKDATE} -ne 1 ]; then
# 
80
    echo "User/Date Stamp Header Comment, e.g. ':\$User$ \$Date$' missing in 
first line of"
    echo "source file:${FILES}"
    echo $ABORTMSG
    exit 7
  fi
  sed -i "s/\\\$User[^\\\$]*\\\$/\\\$User\\\$/; 
s/\\\$Date[^\\\$]*\\\$/\\\$Date\\\$/; s/\\\$User[^\\\$]*\\\$/\\\$User: 
`whoami`\\\$/; s/\\\$Date[^\\\$]*\\\$/\\\$Date: `date`\\\$/" ${FILES}
  if [ $? -ne 0 ]; then
    echo "Error in user/date stamp substitution for file ${FILES}"
    echo $ABORTMSG
    exit 5
  fi
  git add ${FILES}
  if [ $? -ne 0 ]; then
    echo "Error in re-staging (git add) of user/date stamped file ${FILES}"
    echo $ABORTMSG
    exit 8
  fi
  done
# We are not checking error codes on purpose for DDGIT
echo "Running Data Dictionary report (DDGIT)..."
Z -b -o/dev/null DDGIT
wait
echo "Checking for any changes in Data Dictionary report (DDGIT)..."
DIFFDDGIT=`git diff --exit-code DDGIT`
if [ $? -ne 0 ]; then
  echo "Warning: Data Dictionary report (DDGIT) indicates changes to Data 
Dictionary!"
  echo "If DD.idx and DD.dat have changed then a change in DDGIT is 
expected."
  echo "Otherwise, a change in DDGIT is not expected."
  echo "REVIEW THE OLD&NEW DDGIT OUTPUT DIFF AND VERIFY THAT *ALL* CHANGES 
ARE EXPECTED!"
  echo "If the format of the DDGIT output is suspect, then consult with the 
DD Admin."
  echo "After validating *ALL* DD changes, run 'git add DDGIT' and rerun the 
commit."
  echo $ABORTMSG
  exit 9
fi
echo "Info: no changes found in Data Dictionary report (DDGIT)."
echo "...end of pre-commit hook."
exit 0


v/r,
Neal 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: can pre-commit hook accept user input?
  2010-05-22  1:41 can pre-commit hook accept user input? Neal Kreitzinger
@ 2010-05-22  1:45 ` Shawn O. Pearce
  2010-05-22 12:11 ` Marc Weber
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn O. Pearce @ 2010-05-22  1:45 UTC (permalink / raw)
  To: Neal Kreitzinger; +Cc: git

Neal Kreitzinger <neal@rsss.com> wrote:
> Can the pre-commit hook accept user input?

No.  None of the hooks accept user input.

-- 
Shawn.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: can pre-commit hook accept user input?
  2010-05-22  1:41 can pre-commit hook accept user input? Neal Kreitzinger
  2010-05-22  1:45 ` Shawn O. Pearce
@ 2010-05-22 12:11 ` Marc Weber
  1 sibling, 0 replies; 3+ messages in thread
From: Marc Weber @ 2010-05-22 12:11 UTC (permalink / raw)
  To: git

Excerpts from Neal Kreitzinger's message of Sat May 22 03:41:11 +0200 2010:
> Can the pre-commit hook accept user input?  I'm new to linux and bash 

Maybe try describing why you want to add this hook?
Which purpose does it have?
Maybe there is another way to get what you want.

There may be some ways using new ttys and such to be able to read from
stdin again. Maybe even use tools such as xmessage or gui inputs.

But this should be a personal hack only then - because I don't know
exactly those hooks are run. So tell more about the "why" and maybe
you'll get much feedback about the "how" to do it.

Marc Weber

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-05-22 12:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-22  1:41 can pre-commit hook accept user input? Neal Kreitzinger
2010-05-22  1:45 ` Shawn O. Pearce
2010-05-22 12:11 ` Marc Weber

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).