From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Cc: Jakub Narebski <jnareb@gmail.com>,
Eric Wong <normalperson@yhbt.net>,
Pavan Kumar Sunkara <pavan.sss1991@gmail.com>,
Petr Baudis <pasky@suse.cz>,
Christian Couder <chriscool@tuxfamily.org>
Subject: [PATCH 1/3] git-instaweb: Remove pidfile after stopping web server
Date: Fri, 28 May 2010 21:11:23 +0200 [thread overview]
Message-ID: <1275073885-26537-2-git-send-email-jnareb@gmail.com> (raw)
In-Reply-To: <1275073885-26537-1-git-send-email-jnareb@gmail.com>
This way running e.g. "git instaweb" after "git instaweb --stop" would
not try to kill already stopped web server.
This is probably important only for those web servers that are
"daemonized" by git-instaweb itself, i.e. for those where it is
git-instaweb that creates pidfile. Currently it is includes only
'mongoose' web server, but it would also include 'plackup' web server
(added in later commit).
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
git-instaweb.sh | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-instaweb.sh b/git-instaweb.sh
index 5c700b6..a8c5dc0 100755
--- a/git-instaweb.sh
+++ b/git-instaweb.sh
@@ -114,6 +114,7 @@ EOF
stop_httpd () {
test -f "$fqgitdir/pid" && kill $(cat "$fqgitdir/pid")
+ rm -f "$fqgitdir/pid"
}
while test $# != 0
--
1.7.0.1
next prev parent reply other threads:[~2010-05-28 19:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 19:11 [PATCH 0/3] git-instaweb: Support for 'plackup' and improvements Jakub Narebski
2010-05-28 19:11 ` Jakub Narebski [this message]
2010-05-28 19:11 ` [PATCH 2/3] git-instaweb: Wait for server to start before running web browser Jakub Narebski
2010-05-28 19:31 ` Pavan Kumar Sunkara
2010-05-28 19:58 ` Jakub Narebski
2010-05-28 19:11 ` [PATCHv4 3/3] git-instaweb: Add support for running gitweb via 'plackup' Jakub Narebski
2010-05-29 2:32 ` Eric Wong
2010-05-29 7:21 ` Eric Wong
2010-05-31 21:15 ` [PATCH 0/3] git-instaweb: Support for 'plackup' and improvements Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275073885-26537-2-git-send-email-jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=pasky@suse.cz \
--cc=pavan.sss1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).