From: Ramkumar Ramachandra <artagnon@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>
Cc: Sverre Rabbelier <srabbelier@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 1/3] Set cmdline globally, not in stop_here_user_resolve
Date: Tue, 1 Jun 2010 11:20:20 +0200 [thread overview]
Message-ID: <1275384022-12131-2-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1275384022-12131-1-git-send-email-artagnon@gmail.com>
Set the $cmdline variable globally, so it can be used in other code
fragments as well. Also, instead of hardcoding the string "git am",
use the command line argument "$0".
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
git-am.sh | 19 ++++++++++---------
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/git-am.sh b/git-am.sh
index 87ffae2..b779277 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -52,6 +52,16 @@ else
HAS_HEAD=
fi
+cmdline="$0"
+if test '' != "$interactive"
+then
+ cmdline="$cmdline -i"
+fi
+if test '' != "$threeway"
+then
+ cmdline="$cmdline -3"
+fi
+
sq () {
git rev-parse --sq-quote "$@"
}
@@ -66,15 +76,6 @@ stop_here_user_resolve () {
printf '%s\n' "$resolvemsg"
stop_here $1
fi
- cmdline="git am"
- if test '' != "$interactive"
- then
- cmdline="$cmdline -i"
- fi
- if test '' != "$threeway"
- then
- cmdline="$cmdline -3"
- fi
echo "When you have resolved this problem run \"$cmdline --resolved\"."
echo "If you would prefer to skip this patch, instead run \"$cmdline --skip\"."
echo "To restore the original branch and stop patching run \"$cmdline --abort\"."
--
1.7.1
next prev parent reply other threads:[~2010-06-01 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 9:20 [PATCH 0/3] Improve git-am error messages Ramkumar Ramachandra
2010-06-01 9:20 ` Ramkumar Ramachandra [this message]
2010-06-01 9:27 ` [PATCH 1/3] Set cmdline globally, not in stop_here_user_resolve Johannes Sixt
2010-06-01 9:36 ` Ramkumar Ramachandra
2010-06-01 9:20 ` [PATCH 2/3] Display some help text when patch is empty Ramkumar Ramachandra
2010-06-01 9:20 ` [PATCH 3/3] Remove stray error message from sed Ramkumar Ramachandra
2010-06-01 17:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275384022-12131-2-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).