git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Add the option to not sync after a submitting to Perforce.
@ 2010-06-04 17:33 Benjamin C Meyer
  0 siblings, 0 replies; only message in thread
From: Benjamin C Meyer @ 2010-06-04 17:33 UTC (permalink / raw)
  To: git; +Cc: Benjamin C Meyer

When p4->git syncing occurs not on the users machine, but on a central
mirror server there is no local remote.  When a user performs a
'git p4 submit' in this configuration after successfully applying the
patches the p4 submit command will then output a failure because it could
not p4 sync.  This causes users to think their submit failed when in
fact it was successful.

Signed-off-by: Benjamin C Meyer <bmeyer@rim.com>
---
 contrib/fast-import/git-p4 |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index d42b865..2a9771b 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -823,6 +823,9 @@ class P4Submit(Command):
             print "All changes applied!"
             chdir(self.oldWorkingDirectory)
 
+            if gitConfig("git-p4.syncAfterSubmit") == "false":
+                return True
+
             sync = P4Sync()
             sync.run([])
 
-- 
1.7.1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-06-04 17:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-04 17:33 [PATCH] Add the option to not sync after a submitting to Perforce Benjamin C Meyer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).