From: "Clément Poulain" <clement.poulain@ensimag.imag.fr>
To: git@vger.kernel.org
Cc: spearce@spearce.org, drizzd@aon.at, matthieu.moy@grenoble-inp.fr,
"Clément Poulain" <clement.poulain@ensimag.imag.fr>
Subject: [RFC/PATCH 0/4] git-gui blame: use textconv
Date: Sun, 6 Jun 2010 13:30:44 +0200 [thread overview]
Message-ID: <1275823848-7151-1-git-send-email-clement.poulain@ensimag.imag.fr> (raw)
This patch adds support of textconv to git-gui blame. It is based on the work already done here: http://mid.gmane.org/1275562038-7468-1-git-send-email-axel.bonnet@ensimag.imag.fr, and uses a git-gui patch done by Clemens Buchacher (http://mid.gmane.org/20100415193944.GA5848@localhost) which adds textconv support to git-gui diff.
git-gui blame is based on cat-file to get the content of the file in different revisions. So the patch adds textconv support to cat-file.
After a discussion with Jeff King and Matthieu Moy, it appears that creating a context cache is a good way to know the pathname of the concerned blob, as textconv needs a pathname to work. The first part of the patch adds this cache
Clément Poulain (4):
sha1_name: creating context cache
textconv: support for cat-file
git-gui: use textconv filter for diff and blame
t/t8007: test textconv support for cat-file
builtin/blame.c | 8 ++--
builtin/cat-file.c | 24 ++++++++++++++-
cache.h | 8 +++++
git-gui/git-gui.sh | 28 +++++++++++++++++-
git-gui/lib/blame.tcl | 18 ++++++++++-
git-gui/lib/diff.tcl | 5 ++-
git-gui/lib/option.tcl | 1 +
sha1_name.c | 19 ++++++++++++
t/t8007-cat-file-textconv.sh | 66 ++++++++++++++++++++++++++++++++++++++++++
9 files changed, 168 insertions(+), 9 deletions(-)
create mode 100755 t/t8007-cat-file-textconv.sh
next reply other threads:[~2010-06-06 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-06 11:30 Clément Poulain [this message]
2010-06-06 11:30 ` [RFC/PATCH 1/4] sha1_name: creating context cache Clément Poulain
2010-06-06 11:30 ` [RFC/PATCH 2/4] textconv: support for cat-file Clément Poulain
2010-06-06 11:30 ` [RFC/PATCH 3/4] git-gui: use textconv filter for diff and blame Clément Poulain
2010-06-06 11:30 ` [RFC/PATCH 4/4] t/t8007: test textconv support for cat-file Clément Poulain
2010-06-06 15:56 ` [RFC/PATCH 1/4] sha1_name: creating context cache Matthieu Moy
2010-06-06 22:15 ` Jeff King
2010-06-07 8:34 ` Clément Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275823848-7151-1-git-send-email-clement.poulain@ensimag.imag.fr \
--to=clement.poulain@ensimag.imag.fr \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=matthieu.moy@grenoble-inp.fr \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).